Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 2811583002: Revert of Disable the image notification property on MacOS (Closed)

Created:
3 years, 8 months ago by haraken
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable the image notification property on MacOS (patchset #3 id:40001 of https://codereview.chromium.org/2803303002/ ) Reason for revert: This broke a bunch of webkit tests. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/32377 I think you need to update the test results when you remove the feature. Original issue's description: > Disable the image notification property on MacOS > > This is in preparation for the launch of MacOSX native notifications > where the property is not supported. > > Intent to remove https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IKGgHJOVMYE > > BUG=571056 > > Review-Url: https://codereview.chromium.org/2803303002 > Cr-Commit-Position: refs/heads/master@{#463050} > Committed: https://chromium.googlesource.com/chromium/src/+/ae910dd7ccf483d4c3b57cefafda32f36baf7ab9 TBR=peter@chromium.org,avi@chromium.org,miguelg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=571056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
haraken
Created Revert of Disable the image notification property on MacOS
3 years, 8 months ago (2017-04-10 04:51:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811583002/1
3 years, 8 months ago (2017-04-10 04:51:50 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/187098) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 04:53:41 UTC) #5
Mike West
3 years, 8 months ago (2017-04-10 09:35:47 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698