Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2803303002:
Disable the image notification property on MacOS (Closed)
|
Created:
3 years, 8 months ago by Miguel Garcia Modified:
3 years, 8 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable the image notification property on MacOS
This is in preparation for the launch of MacOSX native notifications
where the property is not supported.
Intent to remove https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IKGgHJOVMYE
BUG=571056
Review-Url: https://codereview.chromium.org/2803303002
Cr-Commit-Position: refs/heads/master@{#463050}
Committed: https://chromium.googlesource.com/chromium/src/+/ae910dd7ccf483d4c3b57cefafda32f36baf7ab9
Patch Set 1 #Patch Set 2 : Fix test #
Total comments: 2
Patch Set 3 : review #
Messages
Total messages: 27 (19 generated)
The CQ bit was checked by miguelg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by miguelg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
miguelg@chromium.org changed reviewers: + peter@chromium.org
lgtm Please link to the Intent to Remove thread on blink-dev@ in your CL description. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IKGgHJOVMYE https://codereview.chromium.org/2803303002/diff/20001/content/child/runtime_f... File content/child/runtime_features.cc (right): https://codereview.chromium.org/2803303002/diff/20001/content/child/runtime_f... content/child/runtime_features.cc:73: // notifications // The Notification Center on Mac OS X does not support content images.
Description was changed from ========== Disable the image notification property on MacOS This is in preparation for the launch of MacOSX native notifications where the property is not supported. BUG=571056 ========== to ========== Disable the image notification property on MacOS This is in preparation for the launch of MacOSX native notifications where the property is not supported. Intent to remove https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IKGgHJOVMYE BUG=571056 ==========
The CQ bit was checked by miguelg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
miguelg@chromium.org changed reviewers: + avi@chromium.org
+Avi for OWNERS https://codereview.chromium.org/2803303002/diff/20001/content/child/runtime_f... File content/child/runtime_features.cc (right): https://codereview.chromium.org/2803303002/diff/20001/content/child/runtime_f... content/child/runtime_features.cc:73: // notifications On 2017/04/07 20:30:16, Peter Beverloo wrote: > // The Notification Center on Mac OS X does not support content images. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by miguelg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org Link to the patchset: https://codereview.chromium.org/2803303002/#ps40001 (title: "review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491603077111390,
"parent_rev": "6a900aa3c26f4a4f29477926c8389e29ed8a7eff", "commit_rev":
"ae910dd7ccf483d4c3b57cefafda32f36baf7ab9"}
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491603077111390,
"parent_rev": "6a900aa3c26f4a4f29477926c8389e29ed8a7eff", "commit_rev":
"ae910dd7ccf483d4c3b57cefafda32f36baf7ab9"}
Message was sent while issue was closed.
Description was changed from ========== Disable the image notification property on MacOS This is in preparation for the launch of MacOSX native notifications where the property is not supported. Intent to remove https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IKGgHJOVMYE BUG=571056 ========== to ========== Disable the image notification property on MacOS This is in preparation for the launch of MacOSX native notifications where the property is not supported. Intent to remove https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IKGgHJOVMYE BUG=571056 Review-Url: https://codereview.chromium.org/2803303002 Cr-Commit-Position: refs/heads/master@{#463050} Committed: https://chromium.googlesource.com/chromium/src/+/ae910dd7ccf483d4c3b57cefafda... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ae910dd7ccf483d4c3b57cefafda...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2811583002/ by haraken@chromium.org. The reason for reverting is: This broke a bunch of webkit tests. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1... I think you need to update the test results when you remove the feature. .
Message was sent while issue was closed.
mkwst@chromium.org changed reviewers: + mkwst@chromium.org
Message was sent while issue was closed.
Automatic revert failed, reverting manually in https://codereview.chromium.org/2806233003. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
