Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2806233003: Revert of Disable the image notification property on MacOS (patchset #3 id:40001 of https://coderev… (Closed)

Created:
3 years, 8 months ago by Mike West
Modified:
3 years, 8 months ago
CC:
chromium-reviews, Peter Beverloo, jam, mlamouri+watch-notifications_chromium.org, darin-cc_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable the image notification property on MacOS (patchset #3 id:40001 of https://codereview.chromium.org/2803303002/ ) Reason for revert: This broke a bunch of webkit tests. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/32377 I think you need to update the test results when you remove the feature. Original issue's description: > Disable the image notification property on MacOS > > This is in preparation for the launch of MacOSX native notifications > where the property is not supported. > > Intent to remove https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IKGgHJOVMYE > > BUG=571056 > > Review-Url: https://codereview.chromium.org/2803303002 > Cr-Commit-Position: refs/heads/master@{#463050} > Committed: https://chromium.googlesource.com/chromium/src/+/ae910dd7ccf483d4c3b57cefafda32f36baf7ab9 TBR=peter@chromium.org,avi@chromium.org,miguelg@chromium.org BUG=571056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806233003/1
3 years, 8 months ago (2017-04-10 09:36:31 UTC) #2
Miguel Garcia
lgtm My apologies, was just trying to revert manually myself
3 years, 8 months ago (2017-04-10 09:39:45 UTC) #3
Mike West
On 2017/04/10 at 09:39:45, miguelg wrote: > lgtm > > My apologies, was just trying ...
3 years, 8 months ago (2017-04-10 10:01:51 UTC) #4
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 8 months ago (2017-04-10 10:36:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806233003/1
3 years, 8 months ago (2017-04-10 11:41:34 UTC) #9
Mike West
3 years, 8 months ago (2017-04-10 11:42:31 UTC) #11
On 2017/04/10 at 11:41:34, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

It looks like this landed as
https://chromium.googlesource.com/chromium/src/+/e7498e896f9ad362f3810dfce069...
I have no idea what commit-bot is doing. :)

Powered by Google App Engine
This is Rietveld 408576698