Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/storage

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/storage

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/storage

BUG=707641
Review-Url: https://codereview.chromium.org/2811523002
Cr-Commit-Position: refs/heads/master@{#463430}
Committed: https://chromium.googlesource.com/chromium/src/+/e99b6cfcee3c0d8f7bbd23d308bdd9fe72d0e1e3

[Hwanseung Lee, 2017-04-09 06:03:53]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 06:03:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-09 06:04:12]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/storage

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/storage

BUG=707641
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/storage

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/storage

BUG=707641
==========

[Hwanseung Lee, 2017-04-09 06:04:13]

hs1217.lee@samsung.com changed reviewers:
+ jsbell@chromium.org, tkent@chromium.org

[commit-bot: I haz the power, 2017-04-09 08:20:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 08:20:01]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-09 08:22:23]

PTAL, thank you.

[haraken, 2017-04-09 08:48:12]

LGTM

[Hwanseung Lee, 2017-04-09 08:49:19]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-04-09 08:49:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 21:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 21:51:09]

Failed to apply patch for third_party/WebKit/Source/modules/storage/Storage.cpp:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/modules/storage/Storage.cpp:82
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/modules/storage/Storage.cpp' with
conflicts.
  U third_party/WebKit/Source/modules/storage/Storage.cpp

Patch:       third_party/WebKit/Source/modules/storage/Storage.cpp
Index: third_party/WebKit/Source/modules/storage/Storage.cpp
diff --git a/third_party/WebKit/Source/modules/storage/Storage.cpp
b/third_party/WebKit/Source/modules/storage/Storage.cpp
index
7b79121d3aa2b19d2404ecc33bf13a835198d140..f601a0cf16ff89c6639d3fad0dcebb569c2556a7
100644
--- a/third_party/WebKit/Source/modules/storage/Storage.cpp
+++ b/third_party/WebKit/Source/modules/storage/Storage.cpp
@@ -82,7 +82,7 @@ void Storage::namedPropertyEnumerator(Vector<String>& names,
     String key = this->key(i, exceptionState);
     if (exceptionState.hadException())
       return;
-    ASSERT(!key.isNull());
+    DCHECK(!key.isNull());
     String val = getItem(key, exceptionState);
     if (exceptionState.hadException())
       return;

[Hwanseung Lee, 2017-04-10 15:08:03]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:08:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 16:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:28:24]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-10 22:39:39]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-04-10 22:39:40]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2811523002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-10 22:40:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 22:49:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491863979681080,
"parent_rev": "fb2bf86d665fddf7e580cb67f6be8f3c182188b7", "commit_rev":
"e99b6cfcee3c0d8f7bbd23d308bdd9fe72d0e1e3"}

[commit-bot: I haz the power, 2017-04-10 22:50:27]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/storage

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/storage

BUG=707641
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/storage

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/storage

BUG=707641

Review-Url: https://codereview.chromium.org/2811523002
Cr-Commit-Position: refs/heads/master@{#463430}
Committed:
https://chromium.googlesource.com/chromium/src/+/e99b6cfcee3c0d8f7bbd23d308bd...
==========

[commit-bot: I haz the power, 2017-04-10 22:50:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e99b6cfcee3c0d8f7bbd23d308bd...