third_party/WebKit/Source/modules/storage/Storage.cpp - Issue 2811523002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/storage/Storage.cpp

Issue 2811523002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/storage (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/storage/Storage.cpp

diff --git a/third_party/WebKit/Source/modules/storage/Storage.cpp b/third_party/WebKit/Source/modules/storage/Storage.cpp

index e5694d5974cf89492cf47010754fb47ed13c62dc..47a2814c88f7e7679871e47a991dcfa201b46f20 100644

--- a/third_party/WebKit/Source/modules/storage/Storage.cpp

+++ b/third_party/WebKit/Source/modules/storage/Storage.cpp

@@ -82,7 +82,7 @@ void Storage::NamedPropertyEnumerator(Vector<String>& names,

String key = this->key(i, exception_state);

if (exception_state.HadException())

return;

- ASSERT(!key.IsNull());

+ DCHECK(!key.IsNull());

String val = getItem(key, exception_state);

if (exception_state.HadException())

return;

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/storage/StorageArea.cpp » ('j') | no next file with comments »