Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2811463002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/exported (Closed)

Created:
3 years, 8 months ago by Hwanseung Lee
Modified:
3 years, 5 months ago
Reviewers:
tkent, dcheng1, tzik
CC:
blink-reviews, chromium-reviews, dcheng, kinuko+watch, kinuko+fileapi, nhiroki, tommyw+watchlist_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/exported Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/platform/exported BUG=707663 Review-Url: https://codereview.chromium.org/2811463002 Cr-Commit-Position: refs/heads/master@{#463818} Committed: https://chromium.googlesource.com/chromium/src/+/8c2573026e78bc68e90b1d86aff58649ad855acf

Patch Set 1 #

Patch Set 2 : missing #

Patch Set 3 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -133 lines) Patch
M third_party/WebKit/Source/platform/exported/Platform.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebAudioBus.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebBlobData.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebContentDecryptionModuleResult.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebContentSettingCallbacks.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebCredential.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebCryptoAlgorithm.cpp View 1 2 6 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebCryptoKey.cpp View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebCryptoKeyAlgorithm.cpp View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebCryptoResult.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebDragData.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebFileSystemCallbacks.cpp View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebHTTPBody.cpp View 1 2 6 chunks +7 lines, -7 lines 1 comment Download
M third_party/WebKit/Source/platform/exported/WebHTTPLoadInfo.cpp View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaDeviceInfo.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStream.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamTrack.cpp View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebRTCAnswerOptions.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebRTCICECandidate.cpp View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebRTCOfferOptions.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebRTCSessionDescription.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebRTCSessionDescriptionRequest.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemeClientImpl.cpp View 1 2 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebStorageQuotaCallbacks.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLRequest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (20 generated)
Hwanseung Lee
PTAL, thank you.
3 years, 8 months ago (2017-04-08 10:15:40 UTC) #6
tkent
Please rebase.
3 years, 8 months ago (2017-04-09 22:57:41 UTC) #13
tzik
lgtm
3 years, 8 months ago (2017-04-10 02:31:48 UTC) #14
Hwanseung Lee
@tkent PTAL, thank you.
3 years, 8 months ago (2017-04-11 16:29:15 UTC) #19
tkent
lgtm
3 years, 8 months ago (2017-04-11 22:39:47 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811463002/40001
3 years, 8 months ago (2017-04-11 22:44:03 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/8c2573026e78bc68e90b1d86aff58649ad855acf
3 years, 8 months ago (2017-04-11 22:55:11 UTC) #26
dcheng1
3 years, 5 months ago (2017-07-11 03:15:06 UTC) #28
Message was sent while issue was closed.
https://codereview.chromium.org/2811463002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/exported/WebHTTPBody.cpp (right):

https://codereview.chromium.org/2811463002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/exported/WebHTTPBody.cpp:164:
DCHECK(static_cast<WebHTTPBodyPrivate*>(data.LeakRef()));
Just a friendly reminder to be careful with refactoring CLs. This was an
incorrect change (that's being fixed in
https://chromium-review.googlesource.com/c/565077/); luckily, it seems no code
was using this so nothing broke.

Powered by Google App Engine
This is Rietveld 408576698