Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: third_party/WebKit/Source/platform/exported/Platform.cpp

Issue 2811463002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/exported (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/exported/Platform.cpp
diff --git a/third_party/WebKit/Source/platform/exported/Platform.cpp b/third_party/WebKit/Source/platform/exported/Platform.cpp
index 2adbdd7da179735b47fae248e8303e687550f5de..43a2b3c8070dfdb5acc6d1b14ca053667594872b 100644
--- a/third_party/WebKit/Source/platform/exported/Platform.cpp
+++ b/third_party/WebKit/Source/platform/exported/Platform.cpp
@@ -93,8 +93,8 @@ Platform::Platform() : main_thread_(0) {
}
void Platform::Initialize(Platform* platform) {
- ASSERT(!g_platform);
- ASSERT(platform);
+ DCHECK(!g_platform);
+ DCHECK(platform);
g_platform = platform;
g_platform->main_thread_ = platform->CurrentThread();
@@ -111,7 +111,7 @@ void Platform::Initialize(Platform* platform) {
// TODO(ssid): remove this check after fixing crbug.com/486782.
if (g_platform->main_thread_) {
- ASSERT(!g_gc_task_runner);
+ DCHECK(!g_gc_task_runner);
g_gc_task_runner = new GCTaskRunner(g_platform->main_thread_);
base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
PartitionAllocMemoryDumpProvider::Instance(), "PartitionAlloc",
@@ -126,7 +126,7 @@ void Platform::Initialize(Platform* platform) {
}
void Platform::SetCurrentPlatformForTesting(Platform* platform) {
- ASSERT(platform);
+ DCHECK(platform);
g_platform = platform;
g_platform->main_thread_ = platform->CurrentThread();
}

Powered by Google App Engine
This is Rietveld 408576698