third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h - Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h

diff --git a/third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h b/third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h

index b0db6fc35962fd7845299d6315aa2373c4a59eee..9313ef9914bed3fe5f024b4666b858db0cddf76a 100644

--- a/third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h

+++ b/third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h

@@ -139,8 +139,8 @@ struct URLEscapeSequence {

run += 1;

}

- ASSERT(

- buffer.size() >=

+ DCHECK_GE(

+ buffer.size(),

static_cast<size_t>(p - buffer.data())); // Prove buffer not overrun.

return (encoding.isValid() ? encoding : UTF8Encoding())

.decode(buffer.data(), p - buffer.data());