third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp - Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp

diff --git a/third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp b/third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp

index 6cbab69fc9ee15cc1f173a17fd9be948f9c423e9..201dad272d3b0dc72dba2c3a5f55238041bf10c7 100644

--- a/third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp

+++ b/third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp

@@ -42,7 +42,7 @@ class DateTimeFormatTest : public ::testing::Test {

Token(FieldType fieldType, int count = 1)

: count(count), fieldType(fieldType) {

- ASSERT(fieldType != DateTimeFormat::FieldTypeLiteral);

+ DCHECK_NE(fieldType, DateTimeFormat::FieldTypeLiteral);

}

Token(const String& string)