Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: third_party/WebKit/Source/platform/text/LocaleMac.mm

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/LocaleMac.mm
diff --git a/third_party/WebKit/Source/platform/text/LocaleMac.mm b/third_party/WebKit/Source/platform/text/LocaleMac.mm
index 11b5ddf0aeae860910d2881426b3bd9b4346738f..19abdf72e477b3b11846eb2be56f75fe9c768110 100644
--- a/third_party/WebKit/Source/platform/text/LocaleMac.mm
+++ b/third_party/WebKit/Source/platform/text/LocaleMac.mm
@@ -316,11 +316,11 @@ void LocaleMac::initializeLocaleData() {
Vector<String, DecimalSymbolsSize> symbols;
for (unsigned i = 0; i < 10; ++i)
symbols.push_back(nineToZero.substring(9 - i, 1));
- ASSERT(symbols.size() == DecimalSeparatorIndex);
+ DCHECK(symbols.size() == DecimalSeparatorIndex);
tkent 2017/04/09 23:07:01 Use DCHECK_EQ if it doesn't cause a compile failur
Hwanseung Lee 2017/04/11 03:29:38 it was cause a compile failure.
symbols.push_back([formatter.get() decimalSeparator]);
- ASSERT(symbols.size() == GroupSeparatorIndex);
+ DCHECK(symbols.size() == GroupSeparatorIndex);
tkent 2017/04/09 23:07:01 Use DCHECK_EQ if it doesn't cause a compile failur
Hwanseung Lee 2017/04/11 03:29:38 it was cause a compile failure.
symbols.push_back([formatter.get() groupingSeparator]);
- ASSERT(symbols.size() == DecimalSymbolsSize);
+ DCHECK(symbols.size() == DecimalSymbolsSize);
tkent 2017/04/09 23:07:01 Use DCHECK_EQ if it doesn't cause a compile failur
Hwanseung Lee 2017/04/11 03:29:38 it was cause a compile failure.
String positivePrefix([formatter.get() positivePrefix]);
String positiveSuffix([formatter.get() positiveSuffix]);

Powered by Google App Engine
This is Rietveld 408576698