third_party/WebKit/Source/platform/text/CharacterEmoji.cpp - Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/CharacterEmoji.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/CharacterEmoji.cpp

diff --git a/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp b/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp

index 21bcdf33993504609eb87a3df7bcc0af25651114..0bd561284af18d7faf97528ce4e6cac40a5500b4 100644

--- a/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp

+++ b/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp

@@ -189,7 +189,7 @@ static void applyPatternAndFreeze(icu::UnicodeSet* unicodeSet,

// Use ICU's invariant-character initialization method.

unicodeSet->applyPattern(icu::UnicodeString(pattern, -1, US_INV), err);

unicodeSet->freeze();

- ASSERT(err == U_ZERO_ERROR);

+ DCHECK_EQ(err, U_ZERO_ERROR);

}

bool Character::isEmoji(UChar32 ch) {