third_party/WebKit/Source/platform/text/Character.cpp - Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/Character.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/Character.cpp

diff --git a/third_party/WebKit/Source/platform/text/Character.cpp b/third_party/WebKit/Source/platform/text/Character.cpp

index 7bd0fe5833365589ce3592ba198f3b4905b0de0f..16a75eac2b2beb0a73e5458f53852a9852b2ab5a 100644

--- a/third_party/WebKit/Source/platform/text/Character.cpp

+++ b/third_party/WebKit/Source/platform/text/Character.cpp

@@ -84,7 +84,7 @@ static UTrie2* createTrie() {

UTrie2* trie = utrie2_openFromSerialized(

UTrie2ValueBits::UTRIE2_16_VALUE_BITS, serializedCharacterData,

serializedCharacterDataSize, nullptr, &error);

- ASSERT(error == U_ZERO_ERROR);

+ DCHECK_EQ(error, U_ZERO_ERROR);

return trie;

}