Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/Source/platform/text/BidiRunList.h

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/BidiRunList.h
diff --git a/third_party/WebKit/Source/platform/text/BidiRunList.h b/third_party/WebKit/Source/platform/text/BidiRunList.h
index 21c1be3dcb784a7b600c9a4cee20fda40aad347b..998458002b2cb5787abe128eef9783aa3ef14cc4 100644
--- a/third_party/WebKit/Source/platform/text/BidiRunList.h
+++ b/third_party/WebKit/Source/platform/text/BidiRunList.h
@@ -81,7 +81,7 @@ inline void BidiRunList<Run>::addRun(Run* run) {
template <class Run>
inline void BidiRunList<Run>::prependRun(Run* run) {
- ASSERT(!run->m_next);
+ DCHECK(!run->m_next);
if (!m_lastRun)
m_lastRun = run;
@@ -93,9 +93,9 @@ inline void BidiRunList<Run>::prependRun(Run* run) {
template <class Run>
inline void BidiRunList<Run>::moveRunToEnd(Run* run) {
- ASSERT(m_firstRun);
- ASSERT(m_lastRun);
- ASSERT(run->m_next);
+ DCHECK(m_firstRun);
+ DCHECK(m_lastRun);
+ DCHECK(run->m_next);
Run* current = 0;
Run* next = m_firstRun;
@@ -116,9 +116,9 @@ inline void BidiRunList<Run>::moveRunToEnd(Run* run) {
template <class Run>
inline void BidiRunList<Run>::moveRunToBeginning(Run* run) {
- ASSERT(m_firstRun);
- ASSERT(m_lastRun);
- ASSERT(run != m_firstRun);
+ DCHECK(m_firstRun);
+ DCHECK(m_lastRun);
+ DCHECK_NE(run, m_firstRun);
Run* current = m_firstRun;
Run* next = current->next();
@@ -138,9 +138,9 @@ inline void BidiRunList<Run>::moveRunToBeginning(Run* run) {
template <class Run>
void BidiRunList<Run>::replaceRunWithRuns(Run* toReplace,
BidiRunList<Run>& newRuns) {
- ASSERT(newRuns.runCount());
- ASSERT(m_firstRun);
- ASSERT(toReplace);
+ DCHECK(newRuns.runCount());
+ DCHECK(m_firstRun);
+ DCHECK(toReplace);
if (m_firstRun == toReplace) {
m_firstRun = newRuns.firstRun();
@@ -149,7 +149,7 @@ void BidiRunList<Run>::replaceRunWithRuns(Run* toReplace,
Run* previousRun = m_firstRun;
while (previousRun->next() != toReplace)
previousRun = previousRun->next();
- ASSERT(previousRun);
+ DCHECK(previousRun);
previousRun->setNext(newRuns.firstRun());
}
@@ -192,11 +192,11 @@ void BidiRunList<Run>::deleteRuns() {
template <class Run>
void BidiRunList<Run>::reverseRuns(unsigned start, unsigned end) {
- ASSERT(m_runCount);
+ DCHECK(m_runCount);
if (start >= end)
return;
- ASSERT(end < m_runCount);
+ DCHECK_LT(end, m_runCount);
// Get the item before the start of the runs to reverse and put it in
// |beforeStart|. |curr| should point to the first run to reverse.

Powered by Google App Engine
This is Rietveld 408576698