third_party/WebKit/Source/platform/text/BidiContext.h - Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/BidiContext.h

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/BidiContext.h

diff --git a/third_party/WebKit/Source/platform/text/BidiContext.h b/third_party/WebKit/Source/platform/text/BidiContext.h

index 5d135a39531068149aba74d3ce181252d4c649c9..39989917dcc072aa0e8cf8855a4e4f1a5a4de0ba 100644

--- a/third_party/WebKit/Source/platform/text/BidiContext.h

+++ b/third_party/WebKit/Source/platform/text/BidiContext.h

@@ -71,7 +71,7 @@ class PLATFORM_EXPORT BidiContext : public RefCounted<BidiContext> {

m_override(override),

m_source(source),

m_parent(parent) {

- ASSERT(level <= kMaxLevel);

+ DCHECK(level <= kMaxLevel);

tkent 2017/04/09 23:07:01 Use DCHECK_LE if it doesn't cause a compile failur

Hwanseung Lee 2017/04/11 03:29:38 it was cause a compile failure.

}

static PassRefPtr<BidiContext> createUncached(unsigned char level,