third_party/WebKit/Source/platform/text/BidiCharacterRun.h - Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/BidiCharacterRun.h

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/BidiCharacterRun.h

diff --git a/third_party/WebKit/Source/platform/text/BidiCharacterRun.h b/third_party/WebKit/Source/platform/text/BidiCharacterRun.h

index f8f839c7c6c4bd9c828d858405c1c6055817465b..e8c17e5c1e5eeaa14e3eed11acadadee8817ea17 100644

--- a/third_party/WebKit/Source/platform/text/BidiCharacterRun.h

+++ b/third_party/WebKit/Source/platform/text/BidiCharacterRun.h

@@ -39,7 +39,7 @@ struct BidiCharacterRun {

m_next(0),

m_start(start),

m_stop(stop) {

- ASSERT(m_start <= m_stop);

+ DCHECK_LE(m_start, m_stop);

if (dir == WTF::Unicode::OtherNeutral)

dir = overrideDir;