Remove ListValue::Append(raw ptr) on Android

content/renderer/java/gin_java_function_invocation_helper.cc

Index: content/renderer/java/gin_java_function_invocation_helper.cc
diff --git a/content/renderer/java/gin_java_function_invocation_helper.cc b/content/renderer/java/gin_java_function_invocation_helper.cc
index af300a2e229f4e197c5a2c8ced7287a7050e9e21..a88b51ae06317e0f43a52f8bbced65bf1e9000dc 100644
--- a/content/renderer/java/gin_java_function_invocation_helper.cc
+++ b/content/renderer/java/gin_java_function_invocation_helper.cc
@@ -4,6 +4,8 @@
 
 #include "content/renderer/java/gin_java_function_invocation_helper.h"
 
+#include <utility>
+
 #include "base/memory/ptr_util.h"

[jdoerrie, 2017/04/12 16:08:55]

#include "base/values.h"

[vabr (Chromium), 2017/04/12 16:40:53]

Done.

 #include "content/common/android/gin_java_bridge_errors.h"
 #include "content/common/android/gin_java_bridge_value.h"
@@ -64,7 +66,7 @@ v8::Local<v8::Value> GinJavaFunctionInvocationHelper::Invoke(
     while (args->GetNext(&val)) {
       std::unique_ptr<base::Value> arg(converter_->FromV8Value(val, context));
       if (arg.get()) {
-        arguments.Append(arg.release());
+        arguments.Append(std::move(arg));

[jdoerrie, 2017/04/12 16:08:55]

Consider removing braces around if and else.

[vabr (Chromium), 2017/04/12 16:40:53]

Admittedly, this file is itself not consistent in this respect, so I don't see
harm removing the braces. My personal preference is to always keep them just to
save the mental effort to check if they should be there or not, but I don't feel
strongly here. :)

[jdoerrie, 2017/04/12 18:30:19]

Alright, sounds good :) I am not feeling too strongly about it either, I just
have gotten used to not seeing them for one-line statements. Both versions are
fine according to the style guide IIRC, so it's fine either way.

       } else {
         arguments.Append(base::MakeUnique<base::Value>());
       }