Remove ListValue::Append(raw ptr) on Android

content/renderer/java/gin_java_bridge_value_converter.cc

Index: content/renderer/java/gin_java_bridge_value_converter.cc
diff --git a/content/renderer/java/gin_java_bridge_value_converter.cc b/content/renderer/java/gin_java_bridge_value_converter.cc
index f080f709fe8a71ce800d235904f431996d8c973f..35717d8c9a03d25f4d7bae24b38c95c31c2a77ea 100644
--- a/content/renderer/java/gin_java_bridge_value_converter.cc
+++ b/content/renderer/java/gin_java_bridge_value_converter.cc
@@ -86,7 +86,7 @@ class TypedArraySerializerImpl : public TypedArraySerializer {
          element != end;
          ++element) {
       const ListType list_value = *element;
-      out->Append(new base::Value(list_value));
+      out->Append(base::MakeUnique<base::Value>(list_value));

[jdoerrie, 2017/04/12 16:08:55]

Inline list_value?

[vabr (Chromium), 2017/04/12 16:40:53]

Done. I admit I was not sure whether the explicit type conversion is important
(without it we could drop the ListType declaration from the template
completely), so I kept it in the inline version.

[jdoerrie, 2017/04/12 18:30:19]

True, good point. I think having ListType explicit is the correct choice. It
could be possible that at some point there will be a base::Value(char)
constructor, setting the type to STRING. This would result in a surprising
change for this code if we dropped the template parameter.

     }
   }