Respect method name overrides in make_computed_style_base.py.

Respect method name overrides in make_computed_style_base.py.

Currently make_computed_style_base.py ignores any overrides to the
setter and initial method names in CSSProperties.json5. This patch
ensures that the generator uses the overridden names (which are already
handled in its parent class, StyleBuilderWriter, and stored in
property_['setter'] and property_['initial']).

This patch does not change any generated code.

BUG=710496
Review-Url: https://codereview.chromium.org/2811183004
Cr-Commit-Position: refs/heads/master@{#464295}
Committed: https://chromium.googlesource.com/chromium/src/+/4b44200a3a78e42f34af7f888ebb6e68ee7b1687

[shend, 2017-04-12 00:56:25]

Description was changed from

==========
Respect method name overrides in make_computed_style_base.py.

Currently make_computed_style_base.py ignores any overrides to the
setter and initial method names in CSSProperties.json5. This patch
ensures that the generator uses the overridden names (which are already
handled in StyleBuilderWriter, the parent class of
make_computed_style_base).

BUG=710496
==========

to

==========
Respect method name overrides in make_computed_style_base.py.

Currently make_computed_style_base.py ignores any overrides to the
setter and initial method names in CSSProperties.json5. This patch
ensures that the generator uses the overridden names (which are already
handled in its parent class, StyleBuilderWriter, and stored in
property_['setter'] and property_['initial']).

BUG=710496
==========

[shend, 2017-04-12 00:56:48]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[shend, 2017-04-12 00:56:57]

Description was changed from

==========
Respect method name overrides in make_computed_style_base.py.

Currently make_computed_style_base.py ignores any overrides to the
setter and initial method names in CSSProperties.json5. This patch
ensures that the generator uses the overridden names (which are already
handled in its parent class, StyleBuilderWriter, and stored in
property_['setter'] and property_['initial']).

BUG=710496
==========

to

==========
Respect method name overrides in make_computed_style_base.py.

Currently make_computed_style_base.py ignores any overrides to the
setter and initial method names in CSSProperties.json5. This patch
ensures that the generator uses the overridden names (which are already
handled in its parent class, StyleBuilderWriter, and stored in
property_['setter'] and property_['initial']).

This patch does not change any generated code.

BUG=710496
==========

[commit-bot: I haz the power, 2017-04-12 00:57:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-04-12 01:00:13]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-04-12 01:00:14]

Hi Alan, PTAL :)

[commit-bot: I haz the power, 2017-04-12 02:56:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 02:56:51]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-04-12 05:29:45]

lgtm

[Łukasz Anforowicz, 2017-04-12 15:58:39]

lukasza@chromium.org changed reviewers:
+ lukasza@chromium.org

[Łukasz Anforowicz, 2017-04-12 15:58:40]

Great - thank you very much for patching up my ad-hoc changes made for the Blink
Rename :-)

[shend, 2017-04-12 22:22:38]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 22:23:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 22:29:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 22:29:14]

Dry run: This issue passed the CQ dry run.

[shend, 2017-04-12 22:30:06]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-04-12 22:30:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-04-12 22:35:08]

On 2017/04/12 at 15:58:40, lukasza wrote:
> Great - thank you very much for patching up my ad-hoc changes made for the
Blink Rename :-)

No worries, it was something that we should've done anyway :)

[commit-bot: I haz the power, 2017-04-13 04:34:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492036206404520, "parent_rev":
"f4d149a7634e5c47d8116e0bfa503f98d189f233", "commit_rev":
"4b44200a3a78e42f34af7f888ebb6e68ee7b1687"}

[commit-bot: I haz the power, 2017-04-13 04:39:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492036206404520, "parent_rev":
"f4d149a7634e5c47d8116e0bfa503f98d189f233", "commit_rev":
"4b44200a3a78e42f34af7f888ebb6e68ee7b1687"}

[commit-bot: I haz the power, 2017-04-13 04:39:39]

Description was changed from

==========
Respect method name overrides in make_computed_style_base.py.

Currently make_computed_style_base.py ignores any overrides to the
setter and initial method names in CSSProperties.json5. This patch
ensures that the generator uses the overridden names (which are already
handled in its parent class, StyleBuilderWriter, and stored in
property_['setter'] and property_['initial']).

This patch does not change any generated code.

BUG=710496
==========

to

==========
Respect method name overrides in make_computed_style_base.py.

Currently make_computed_style_base.py ignores any overrides to the
setter and initial method names in CSSProperties.json5. This patch
ensures that the generator uses the overridden names (which are already
handled in its parent class, StyleBuilderWriter, and stored in
property_['setter'] and property_['initial']).

This patch does not change any generated code.

BUG=710496

Review-Url: https://codereview.chromium.org/2811183004
Cr-Commit-Position: refs/heads/master@{#464295}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b44200a3a78e42f34af7f888ebb...
==========

[commit-bot: I haz the power, 2017-04-13 04:39:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b44200a3a78e42f34af7f888ebb...