Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2801523002:
Allow ComputedStyleBase property fields to be storage_only. (Closed)
DescriptionAllow ComputedStyleBase property fields to be storage_only.
Currently the 'storage_only' template can only be applied to nonproperty
fields because 'storage_only' is not a valid value for 'template' in
CSSProperties.json5. However, there are cases when we want a property
field to be 'storage_only' (e.g. for color related properties whose
getters are very complex).
This patch adds 'storage_only' as a valid template option in
CSSProperties.json5.
BUG=628043
Review-Url: https://codereview.chromium.org/2801523002
Cr-Commit-Position: refs/heads/master@{#463874}
Committed: https://chromium.googlesource.com/chromium/src/+/83e9ff4b5ed44bf5c2196f3bdfdde63a07c6072e
Patch Set 1 #Patch Set 2 : Update comments #Patch Set 3 : Rebase #Patch Set 4 : Rebase correctly #Patch Set 5 : Rebase #
Dependent Patchsets: Messages
Total messages: 27 (20 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
shend@chromium.org changed reviewers: + bugsnash@chromium.org
Hi Bugs, PTAL
shend@chromium.org changed reviewers: + nainar@chromium.org - bugsnash@chromium.org
Giving this to Naina instead, PTAL
lgtm
shend@chromium.org changed reviewers: + alancutter@chromium.org
Hi Alan, PTAL
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Allow ComputedStyleBase property fields to be storage_only. Currently the 'storage_only' template can only be applied to nonproperty fields because 'storage_only' is not a valid value for 'template' in CSSProperties.json5. However, there are cases when we want a property field to be 'storage_only' (e.g. shorthand properties). This patch adds 'storage_only' as a valid template option in CSSProperties.json5. Since 'storage_only' fields require a 'field_size', we also add 'field_size' as a valid key in CSSProperties.json5. BUG=628043 ========== to ========== Allow ComputedStyleBase property fields to be storage_only. Currently the 'storage_only' template can only be applied to nonproperty fields because 'storage_only' is not a valid value for 'template' in CSSProperties.json5. However, there are cases when we want a property field to be 'storage_only' (e.g. temporarily for shorthand properties, for color related properties whose getters are very complex). This patch adds 'storage_only' as a valid template option in CSSProperties.json5. Since 'storage_only' fields require a 'field_size', we also add 'field_size' as a valid key in CSSProperties.json5. BUG=628043 ==========
Description was changed from ========== Allow ComputedStyleBase property fields to be storage_only. Currently the 'storage_only' template can only be applied to nonproperty fields because 'storage_only' is not a valid value for 'template' in CSSProperties.json5. However, there are cases when we want a property field to be 'storage_only' (e.g. temporarily for shorthand properties, for color related properties whose getters are very complex). This patch adds 'storage_only' as a valid template option in CSSProperties.json5. Since 'storage_only' fields require a 'field_size', we also add 'field_size' as a valid key in CSSProperties.json5. BUG=628043 ========== to ========== Allow ComputedStyleBase property fields to be storage_only. Currently the 'storage_only' template can only be applied to nonproperty fields because 'storage_only' is not a valid value for 'template' in CSSProperties.json5. However, there are cases when we want a property field to be 'storage_only' (e.g. for color related properties whose getters are very complex). This patch adds 'storage_only' as a valid template option in CSSProperties.json5. Since 'storage_only' fields require a 'field_size', we also add 'field_size' as a valid key in CSSProperties.json5. BUG=628043 ==========
Description was changed from ========== Allow ComputedStyleBase property fields to be storage_only. Currently the 'storage_only' template can only be applied to nonproperty fields because 'storage_only' is not a valid value for 'template' in CSSProperties.json5. However, there are cases when we want a property field to be 'storage_only' (e.g. for color related properties whose getters are very complex). This patch adds 'storage_only' as a valid template option in CSSProperties.json5. Since 'storage_only' fields require a 'field_size', we also add 'field_size' as a valid key in CSSProperties.json5. BUG=628043 ========== to ========== Allow ComputedStyleBase property fields to be storage_only. Currently the 'storage_only' template can only be applied to nonproperty fields because 'storage_only' is not a valid value for 'template' in CSSProperties.json5. However, there are cases when we want a property field to be 'storage_only' (e.g. for color related properties whose getters are very complex). This patch adds 'storage_only' as a valid template option in CSSProperties.json5. BUG=628043 ==========
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org Link to the patchset: https://codereview.chromium.org/2801523002/#ps80001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491959022505400,
"parent_rev": "4f2f788a1a1fcb7cb0c12dbee0d7a07378b8595c", "commit_rev":
"83e9ff4b5ed44bf5c2196f3bdfdde63a07c6072e"}
Message was sent while issue was closed.
Description was changed from ========== Allow ComputedStyleBase property fields to be storage_only. Currently the 'storage_only' template can only be applied to nonproperty fields because 'storage_only' is not a valid value for 'template' in CSSProperties.json5. However, there are cases when we want a property field to be 'storage_only' (e.g. for color related properties whose getters are very complex). This patch adds 'storage_only' as a valid template option in CSSProperties.json5. BUG=628043 ========== to ========== Allow ComputedStyleBase property fields to be storage_only. Currently the 'storage_only' template can only be applied to nonproperty fields because 'storage_only' is not a valid value for 'template' in CSSProperties.json5. However, there are cases when we want a property field to be 'storage_only' (e.g. for color related properties whose getters are very complex). This patch adds 'storage_only' as a valid template option in CSSProperties.json5. BUG=628043 Review-Url: https://codereview.chromium.org/2801523002 Cr-Commit-Position: refs/heads/master@{#463874} Committed: https://chromium.googlesource.com/chromium/src/+/83e9ff4b5ed44bf5c2196f3bdfdd... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/83e9ff4b5ed44bf5c2196f3bdfdd... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
