Setup download internal directory

Setup download internal directory for invisible downloads

This CL sets up a download internal directory which can be used by clients
such as background fetch to store downloaded files that are not publicly
visible. Callers of DownloadManager::DownloadUrl can specify a download
path which in conjunction with transient flag will set up a pre-set path
for the downloaded file.

BUG=710669
Review-Url: https://codereview.chromium.org/2811173002
Cr-Commit-Position: refs/heads/master@{#465066}
Committed: https://chromium.googlesource.com/chromium/src/+/dce5ad6ba91efb62c8df76cf455207b2f70d0cfe

[shaktisahu, 2017-04-11 21:34:24]

Description was changed from

==========
Setup download internal directory

BUG=
==========

to

==========
Setup download internal directory for invisible downloads

This CL sets up a download internal directory which can be used by clients
such as background fetch to store downloaded files that are not publicly
visible. Callers of DownloadManager::DownloadUrl can specify a download
path which in conjunction with transient flag will set up a forced path
for the downloaded file.

BUG=
==========

[shaktisahu, 2017-04-11 21:35:12]

Description was changed from

==========
Setup download internal directory for invisible downloads

This CL sets up a download internal directory which can be used by clients
such as background fetch to store downloaded files that are not publicly
visible. Callers of DownloadManager::DownloadUrl can specify a download
path which in conjunction with transient flag will set up a forced path
for the downloaded file.

BUG=
==========

to

==========
Setup download internal directory for invisible downloads

This CL sets up a download internal directory which can be used by clients
such as background fetch to store downloaded files that are not publicly
visible. Callers of DownloadManager::DownloadUrl can specify a download
path which in conjunction with transient flag will set up a pre-set path
for the downloaded file.

BUG=
==========

[shaktisahu, 2017-04-11 21:35:12]

shaktisahu@chromium.org changed reviewers:
+ dtrainor@chromium.org

[shaktisahu, 2017-04-11 21:40:41]

dtrainor@ - PTAL.

[shaktisahu, 2017-04-11 22:21:51]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 22:22:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2017-04-11 23:03:59]

dtrainor@chromium.org changed reviewers:
+ nyquist@chromium.org

[David Trainor- moved to gerrit, 2017-04-11 23:04:00]

lgtm, but can you set up a big for this and close it out?  Also what were the
implications of clearing the temporary bit?  +nyquist@ for base.

[commit-bot: I haz the power, 2017-04-11 23:05:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 23:05:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shaktisahu, 2017-04-11 23:19:50]

Description was changed from

==========
Setup download internal directory for invisible downloads

This CL sets up a download internal directory which can be used by clients
such as background fetch to store downloaded files that are not publicly
visible. Callers of DownloadManager::DownloadUrl can specify a download
path which in conjunction with transient flag will set up a pre-set path
for the downloaded file.

BUG=
==========

to

==========
Setup download internal directory for invisible downloads

This CL sets up a download internal directory which can be used by clients
such as background fetch to store downloaded files that are not publicly
visible. Callers of DownloadManager::DownloadUrl can specify a download
path which in conjunction with transient flag will set up a pre-set path
for the downloaded file.

BUG=710669
==========

[shaktisahu, 2017-04-12 00:16:14]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 00:16:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 01:13:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 01:13:42]

Dry run: This issue passed the CQ dry run.

[nyquist, 2017-04-17 22:29:31]

base lgtm

[shaktisahu, 2017-04-17 22:36:32]

The CQ bit was checked by shaktisahu@chromium.org

[shaktisahu, 2017-04-17 22:36:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2811173002/#ps20001
(title: "fix browser test")

[commit-bot: I haz the power, 2017-04-17 22:36:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 23:55:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492468592247260,
"parent_rev": "cfc0c0e2ab36bc413c0d0e05da1d19dec7ccd900", "commit_rev":
"dce5ad6ba91efb62c8df76cf455207b2f70d0cfe"}

[commit-bot: I haz the power, 2017-04-17 23:56:00]

Description was changed from

==========
Setup download internal directory for invisible downloads

This CL sets up a download internal directory which can be used by clients
such as background fetch to store downloaded files that are not publicly
visible. Callers of DownloadManager::DownloadUrl can specify a download
path which in conjunction with transient flag will set up a pre-set path
for the downloaded file.

BUG=710669
==========

to

==========
Setup download internal directory for invisible downloads

This CL sets up a download internal directory which can be used by clients
such as background fetch to store downloaded files that are not publicly
visible. Callers of DownloadManager::DownloadUrl can specify a download
path which in conjunction with transient flag will set up a pre-set path
for the downloaded file.

BUG=710669

Review-Url: https://codereview.chromium.org/2811173002
Cr-Commit-Position: refs/heads/master@{#465066}
Committed:
https://chromium.googlesource.com/chromium/src/+/dce5ad6ba91efb62c8df76cf4552...
==========

[commit-bot: I haz the power, 2017-04-17 23:56:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dce5ad6ba91efb62c8df76cf4552...