Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4706)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 2811173002: Setup download internal directory (Closed)
Patch Set: fix browser test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/path_utils.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index 1dd85d0c07fda05fb551c5f09f779e634b748662..34f1024972dd17f67ce52eac720aa8252e97441a 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -2208,7 +2208,6 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadUrlToPath) {
DownloadUrlParameters::CreateForWebContentsMainFrame(
web_contents, url));
params->set_file_path(target_file_full_path);
- params->set_transient(true);
DownloadManagerForBrowser(browser())->DownloadUrl(std::move(params));
observer->WaitForFinished();
EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::COMPLETE));
@@ -2226,7 +2225,39 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadUrlToPath) {
ASSERT_EQ(1u, downloads.size());
content::DownloadUpdatedObserver(
downloads[0], base::Bind(&WasAutoOpened)).WaitForEvent();
+}
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, TransientDownload) {
+ GURL url(URLRequestMockHTTPJob::GetMockUrl(kDownloadTest1Path));
+
+ WebContents* web_contents =
+ browser()->tab_strip_model()->GetActiveWebContents();
+ ASSERT_TRUE(web_contents);
+
+ base::FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
+ base::ScopedTempDir other_directory;
+ ASSERT_TRUE(other_directory.CreateUniqueTempDir());
+ base::FilePath target_file_full_path =
+ other_directory.GetPath().Append(file.BaseName());
+ content::DownloadTestObserver* observer(CreateWaiter(browser(), 1));
+ std::unique_ptr<DownloadUrlParameters> params(
+ DownloadUrlParameters::CreateForWebContentsMainFrame(web_contents, url));
+ params->set_file_path(target_file_full_path);
+ params->set_transient(true);
+ DownloadManagerForBrowser(browser())->DownloadUrl(std::move(params));
+ observer->WaitForFinished();
+ EXPECT_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::COMPLETE));
+
+ // Check state.
+ EXPECT_EQ(1, browser()->tab_strip_model()->count());
+ ASSERT_TRUE(CheckDownloadFullPaths(browser(), target_file_full_path,
+ OriginFile(file)));
+
+ std::vector<DownloadItem*> downloads;
+ DownloadManagerForBrowser(browser())->GetAllDownloads(&downloads);
+ ASSERT_EQ(1u, downloads.size());
ASSERT_TRUE(downloads[0]->IsTransient());
+ ASSERT_FALSE(downloads[0]->IsTemporary());
}
IN_PROC_BROWSER_TEST_F(DownloadTest, SavePageNonHTMLViaGet) {
« no previous file with comments | « base/android/path_utils.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698