Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2811143005: Revert of path: Add tracking of volatile paths. (Closed)

Created:
3 years, 8 months ago by dnj
Modified:
3 years, 8 months ago
Reviewers:
iannucci, nodir
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of path: Add tracking of volatile paths. (patchset #3 id:40001 of https://codereview.chromium.org/2808713003/ ) Reason for revert: different approach, no longer needed, reduce extra complexity. Original issue's description: > path: Add tracking of volatile paths. > > Allow a caller to express to the recipe engine that named paths are > volatile. This can, in turn, be used by recipes to determine if they should > care about residual files in between recipe executions within that path. > > BUG=chromium:708616 > TEST=expectations > > Review-Url: https://codereview.chromium.org/2808713003 > Committed: https://github.com/luci/recipes-py/commit/f31d525eef33613aa537e8ed954e7dfbf1cae8b2 TBR=nodir@chromium.org,iannucci@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:708616 Review-Url: https://codereview.chromium.org/2811143005 Committed: https://github.com/luci/recipes-py/commit/addc0640c912a43c6ea02dbfda992407cc9957ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -115 lines) Patch
M recipe_modules/path/api.py View 3 chunks +5 lines, -21 lines 0 comments Download
M recipe_modules/path/config.py View 2 chunks +1 line, -6 lines 0 comments Download
M recipe_modules/path/example.py View 2 chunks +1 line, -4 lines 0 comments Download
M recipe_modules/path/example.expected/linux.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/linux_kitchen.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/linux_luci.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/linux_swarming.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/mac.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/mac_kitchen.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/mac_luci.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/mac_swarming.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/win.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/win_kitchen.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/win_luci.json View 1 chunk +0 lines, -7 lines 0 comments Download
M recipe_modules/path/example.expected/win_swarming.json View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dnj
Created Revert of path: Add tracking of volatile paths.
3 years, 8 months ago (2017-04-12 14:31:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811143005/1
3 years, 8 months ago (2017-04-12 14:32:04 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 14:35:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/addc0640c912a43c6ea02dbfda992407cc9...

Powered by Google App Engine
This is Rietveld 408576698