path: Add tracking of volatile paths.

path: Add tracking of volatile paths.

Allow a caller to express to the recipe engine that named paths are
volatile. This can, in turn, be used by recipes to determine if they should
care about residual files in between recipe executions within that path.

BUG=chromium:708616
TEST=expectations

Review-Url: https://codereview.chromium.org/2808713003
Committed: https://github.com/luci/recipes-py/commit/f31d525eef33613aa537e8ed954e7dfbf1cae8b2

[dnj, 2017-04-10 16:44:48]

Description was changed from

==========
Add "tmp_dir_volatile" path module property.

Allow a caller to express to the recipe engine that it's temporary
directory is volatile. This can, in turn, be used by recipes to
determine if they should care about residual temporary files in between
recipe executions.

BUG=chromium:708616
TEST=expectations
==========

to

==========
path: Add tracking of volatile paths.

Allow a caller to express to the recipe engine that named paths are
volatile. This can, in turn, be used by recipes to determine if they should
care about residual files in between recipe executions within that path.

BUG=chromium:708616
TEST=expectations
==========

[dnj, 2017-04-10 16:45:06]

Description was changed from

==========
path: Add tracking of volatile paths.

Allow a caller to express to the recipe engine that named paths are
volatile. This can, in turn, be used by recipes to determine if they should
care about residual files in between recipe executions within that path.

BUG=chromium:708616
TEST=expectations
==========

to

==========
path: Add tracking of volatile paths.

Allow a caller to express to the recipe engine that named paths are
volatile. This can, in turn, be used by recipes to determine if they should
care about residual files in between recipe executions within that path.

BUG=chromium:708616
TEST=expectations
==========

[dnj, 2017-04-10 16:45:14]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org, nodir@chromium.org

[dnj, 2017-04-10 16:45:15]

PTAL

[nodir, 2017-04-10 16:59:21]

lgtm

https://codereview.chromium.org/2808713003/diff/20001/recipe_modules/path/api.py
File recipe_modules/path/api.py (right):

https://codereview.chromium.org/2808713003/diff/20001/recipe_modules/path/api...
recipe_modules/path/api.py:207: self._tmp_dir_volatile =
self._test_data.get('tmp_dir_volatile', False)
self._tmp_dir_volatile is not used

https://codereview.chromium.org/2808713003/diff/20001/recipe_modules/path/con...
File recipe_modules/path/config.py (right):

https://codereview.chromium.org/2808713003/diff/20001/recipe_modules/path/con...
recipe_modules/path/config.py:22: volatile_paths = List(str),
i think it should be a Set
because order does not matter

[dnj, 2017-04-10 17:05:20]

https://codereview.chromium.org/2808713003/diff/20001/recipe_modules/path/api.py
File recipe_modules/path/api.py (right):

https://codereview.chromium.org/2808713003/diff/20001/recipe_modules/path/api...
recipe_modules/path/api.py:207: self._tmp_dir_volatile =
self._test_data.get('tmp_dir_volatile', False)
On 2017/04/10 16:59:21, nodir wrote:
> self._tmp_dir_volatile is not used

oh whoops, thanks

https://codereview.chromium.org/2808713003/diff/20001/recipe_modules/path/con...
File recipe_modules/path/config.py (right):

https://codereview.chromium.org/2808713003/diff/20001/recipe_modules/path/con...
recipe_modules/path/config.py:22: volatile_paths = List(str),
On 2017/04/10 16:59:21, nodir wrote:
> i think it should be a Set
> because order does not matter

Done.

[iannucci, 2017-04-10 17:05:33]

I'm not exactly sure how this helps with the linked bug though?

https://codereview.chromium.org/2808713003/diff/20001/recipe_modules/path/con...
File recipe_modules/path/config.py (right):

https://codereview.chromium.org/2808713003/diff/20001/recipe_modules/path/con...
recipe_modules/path/config.py:22: volatile_paths = List(str),
On 2017/04/10 16:59:21, nodir wrote:
> i think it should be a Set
> because order does not matter

+1

[dnj, 2017-04-10 17:05:54]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-04-10 17:05:55]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2808713003/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2017-04-10 17:06:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 17:12:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:12:31]

Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3571a6099f74f010)

[dnj, 2017-04-10 17:17:54]

On 2017/04/10 17:05:33, iannucci wrote:
> I'm not exactly sure how this helps with the linked bug though?

Updated the bug with the plan.

[iannucci, 2017-04-10 17:27:06]

oops, meant to lgtm

[dnj, 2017-04-10 17:27:17]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:27:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 17:30:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491845237949630,
"parent_rev": "86179ebcb99567b956e788bb1a100c262f533083", "commit_rev":
"f31d525eef33613aa537e8ed954e7dfbf1cae8b2"}

[commit-bot: I haz the power, 2017-04-10 17:30:19]

Description was changed from

==========
path: Add tracking of volatile paths.

Allow a caller to express to the recipe engine that named paths are
volatile. This can, in turn, be used by recipes to determine if they should
care about residual files in between recipe executions within that path.

BUG=chromium:708616
TEST=expectations
==========

to

==========
path: Add tracking of volatile paths.

Allow a caller to express to the recipe engine that named paths are
volatile. This can, in turn, be used by recipes to determine if they should
care about residual files in between recipe executions within that path.

BUG=chromium:708616
TEST=expectations

Review-Url: https://codereview.chromium.org/2808713003
Committed:
https://github.com/luci/recipes-py/commit/f31d525eef33613aa537e8ed954e7dfbf1c...
==========

[commit-bot: I haz the power, 2017-04-10 17:30:21]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/f31d525eef33613aa537e8ed954e7dfbf1c...

[dnj, 2017-04-12 14:31:52]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2811143005/ by dnj@chromium.org.

The reason for reverting is: different approach, no longer needed, reduce extra
complexity..