Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2811093002: Print . for 127(DEL) (Closed)

Created:
3 years, 8 months ago by tikuta
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print . for 127(DEL) BUG= Review-Url: https://codereview.chromium.org/2811093002 Cr-Commit-Position: refs/heads/master@{#464334} Committed: https://chromium.googlesource.com/chromium/src/+/df702e868c39760f3d62bdc0dd75b1987a1c4799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/determinism/compare_build_artifacts.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
tikuta1
3 years, 8 months ago (2017-04-11 10:00:07 UTC) #4
Yoshisato Yanagisawa
lgtm
3 years, 8 months ago (2017-04-13 06:43:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811093002/1
3 years, 8 months ago (2017-04-13 06:59:19 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-13 06:59:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811093002/1
3 years, 8 months ago (2017-04-13 07:02:28 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-13 07:02:30 UTC) #13
tikuta1
Can I ask you to commit this CL instead of me?
3 years, 8 months ago (2017-04-13 07:08:00 UTC) #15
shinyak
You have to get LGTM from (valid) committer.
3 years, 8 months ago (2017-04-13 07:23:22 UTC) #16
shinyak
lgtm (the previous comment is not intentional LGTM. This is intentional)
3 years, 8 months ago (2017-04-13 07:24:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811093002/1
3 years, 8 months ago (2017-04-13 07:26:10 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 07:46:14 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df702e868c39760f3d62bdc0dd75...

Powered by Google App Engine
This is Rietveld 408576698