tools/determinism/compare_build_artifacts.py - Issue 2811093002: Print . for 127(DEL)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/determinism/compare_build_artifacts.py

Issue 2811093002: Print . for 127(DEL) (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/determinism/compare_build_artifacts.py

diff --git a/tools/determinism/compare_build_artifacts.py b/tools/determinism/compare_build_artifacts.py

index 1d398e2c3c8c197f045b532276ae9d267c0c2ea6..62dae004bebd4207af4633206d41ec83550cc0b8 100755

--- a/tools/determinism/compare_build_artifacts.py

+++ b/tools/determinism/compare_build_artifacts.py

@@ -131,7 +131,7 @@ def diff_binary(first_filepath, second_filepath, file_len):

result = '%d out of %d bytes are different (%.2f%%)' % (

diffs, file_len, 100.0 * diffs / file_len)

if streams:

- encode = lambda text: ''.join(i if 31 < ord(i) < 128 else '.' for i in text)

+ encode = lambda text: ''.join(i if 31 < ord(i) < 127 else '.' for i in text)

for offset, lhs_data, rhs_data in streams:

lhs_line = '%s \'%s\'' % (lhs_data.encode('hex'), encode(lhs_data))

rhs_line = '%s \'%s\'' % (rhs_data.encode('hex'), encode(rhs_data))

« no previous file with comments | « no previous file | no next file » | no next file with comments »