Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2811083005: Add DocumentMarkerListEditor (Closed)

Created:
3 years, 8 months ago by rlanday
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DocumentMarkerListEditor Step 2 ("Introduce DocumentMarkerListEditor with a bunch of test cases showing that it works properly") of my plan to split up this refactor: https://codereview.chromium.org/2805553003#msg27 BUG=707867

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+612 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp View 1 chunk +222 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditorTest.cpp View 1 1 chunk +333 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2808363005 Patch 20001

Dependent Patchsets:

Issue 2809323002 Patch 1
Issue 2809323002 Patch 20001

Messages

Total messages: 8 (7 generated)
rlanday
3 years, 8 months ago (2017-04-12 01:21:19 UTC) #3 

          

          

        


      

    
      
    
      
    
      
    
      
    
      
    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698