Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2809323002: Add DocumentMarkerList implementation classes (Closed)

Created:
3 years, 8 months ago by rlanday
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DocumentMarkerList implementation classes Step 3 ("Implement specialized DMLImpl classes with test cases") of my plan to split up this refactor: https://codereview.chromium.org/2805553003#msg27 I haven't actually written the tests yet, but I wanted to put this up for review so we can decide if we're on the right track. I can split this up for review but I figured there's more context this way for discussing the design. BUG=707867

Patch Set 1 #

Patch Set 2 : s/moveright/copyright/ #

Messages

Total messages: 10 (7 generated)
rlanday
3 years, 8 months ago (2017-04-12 01:39:02 UTC) #5
rlanday
3 years, 8 months ago (2017-04-12 01:39:11 UTC) #6
yosin_UTC9
3 years, 8 months ago (2017-04-12 01:52:35 UTC) #8
This CL is what I'm afraid of.
We don't want to migrate all DM list types one.
We want to migrate one by one on demand, e.g. we don't need to IME marker at
this time since
it works well in current implementation.

Powered by Google App Engine
This is Rietveld 408576698