Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2808363005: Add DocumentMarkerList interface (Closed)

Created:
3 years, 8 months ago by rlanday
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DocumentMarkerList interface Step 1 ("Introduce DocumentMarkerList interface") of my current plan to split up this refactor: https://codereview.chromium.org/2805553003#msg27 BUG=707867

Patch Set 1 #

Total comments: 1

Patch Set 2 : s/copied/moved, add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2755013004 Patch 400001

Dependent Patchsets:

Issue 2811083005 Patch 1
Issue 2811083005 Patch 20001

Messages

Total messages: 12 (9 generated)
rlanday
3 years, 8 months ago (2017-04-11 23:23:02 UTC) #3
Xiaocheng
https://codereview.chromium.org/2808363005/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h File third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h (right): https://codereview.chromium.org/2808363005/diff/1/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h#newcode27 third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h:27: // Returns true if at least one marker is ...
3 years, 8 months ago (2017-04-12 00:30:51 UTC) #5
rlanday
3 years, 8 months ago (2017-04-12 01:18:42 UTC) #9 
On 2017/04/12 at 00:30:51, xiaochengh wrote:
>
https://codereview.chromium.org/2808363005/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h
(right):
> 
>
https://codereview.chromium.org/2808363005/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h:27: //
Returns true if at least one marker is copied, false otherwise
> Please also document the behavior of this function, i.e., which markers will
be moved and how their offsets will be changed.
> 
> Ditto for the two other functions.
> 
> nit: s/copied/moved/

Updated

Powered by Google App Engine
This is Rietveld 408576698