Chromium Code Reviews
DescriptionRevert of Don't use the DSE geolocation setting when chrome doesn't have location. (patchset #3 id:40001 of https://codereview.chromium.org/2804913005/ )
Reason for revert:
We are going with a server side fix instead for this problem. We should still investigate separately some means of backing off the Update Permissions prompt (e.g. with embargo).
Original issue's description:
> Don't use the DSE geolocation setting when chrome doesn't have location.
>
> The DSE geolocation setting controls whether the default search engine
> should have geolocation access or not, and is on by default. When the
> setting is used and chrome does not have permission at the android
> level, Chrome will ask the user to give Chrome location access.
>
> What this all means is that if the DSE location setting is used on
> a device where Chrome doesn't have geolocation access, the user will
> be prompted to give Chrome location access on every google search
> (whether via the search results page or the omnibox).
>
> This change prevents this by preventing the DSE geolocation setting from
> being used if Chrome doesn't have geolocation access.
>
> BUG=709219
>
> Review-Url: https://codereview.chromium.org/2804913005
> Cr-Commit-Position: refs/heads/master@{#463057}
> Committed: https://chromium.googlesource.com/chromium/src/+/235d2d36366b8eefb2f167de9432f546a7752e47
TBR=dominickn@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=709219
Review-Url: https://codereview.chromium.org/2811073003
Cr-Commit-Position: refs/heads/master@{#463901}
Committed: https://chromium.googlesource.com/chromium/src/+/3a6e489b65f5ad9dd262520e455c5e339d480e7f
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||