Don't use the DSE geolocation setting when chrome doesn't have location.

Don't use the DSE geolocation setting when chrome doesn't have location.

The DSE geolocation setting controls whether the default search engine
should have geolocation access or not, and is on by default. When the
setting is used and chrome does not have permission at the android
level, Chrome will ask the user to give Chrome location access.

What this all means is that if the DSE location setting is used on
a device where Chrome doesn't have geolocation access, the user will
be prompted to give Chrome location access on every google search
(whether via the search results page or the omnibox).

This change prevents this by preventing the DSE geolocation setting from
being used if Chrome doesn't have geolocation access.

BUG=709219
Review-Url: https://codereview.chromium.org/2804913005
Cr-Commit-Position: refs/heads/master@{#463057}
Committed: https://chromium.googlesource.com/chromium/src/+/235d2d36366b8eefb2f167de9432f546a7752e47

[benwells, 2017-04-07 04:52:50]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 04:53:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[benwells, 2017-04-07 04:54:39]

benwells@chromium.org changed reviewers:
+ dominickn@chromium.org

[dominickn, 2017-04-07 05:12:23]

lgtm

[commit-bot: I haz the power, 2017-04-07 06:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 06:22:56]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[benwells, 2017-04-07 06:49:08]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 06:49:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 08:30:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 08:30:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[benwells, 2017-04-07 12:09:54]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 12:10:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 12:54:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 12:54:15]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-04-07 22:58:00]

still lgtm

[benwells, 2017-04-07 23:22:05]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2017-04-07 23:22:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 23:54:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491607325618730,
"parent_rev": "2f8dfeeb7c55d5ccab048863d41c7a34e4ad8688", "commit_rev":
"235d2d36366b8eefb2f167de9432f546a7752e47"}

[commit-bot: I haz the power, 2017-04-07 23:55:16]

Description was changed from

==========
Don't use the DSE geolocation setting when chrome doesn't have location.

The DSE geolocation setting controls whether the default search engine
should have geolocation access or not, and is on by default. When the
setting is used and chrome does not have permission at the android
level, Chrome will ask the user to give Chrome location access.

What this all means is that if the DSE location setting is used on
a device where Chrome doesn't have geolocation access, the user will
be prompted to give Chrome location access on every google search
(whether via the search results page or the omnibox).

This change prevents this by preventing the DSE geolocation setting from
being used if Chrome doesn't have geolocation access.

BUG=709219
==========

to

==========
Don't use the DSE geolocation setting when chrome doesn't have location.

The DSE geolocation setting controls whether the default search engine
should have geolocation access or not, and is on by default. When the
setting is used and chrome does not have permission at the android
level, Chrome will ask the user to give Chrome location access.

What this all means is that if the DSE location setting is used on
a device where Chrome doesn't have geolocation access, the user will
be prompted to give Chrome location access on every google search
(whether via the search results page or the omnibox).

This change prevents this by preventing the DSE geolocation setting from
being used if Chrome doesn't have geolocation access.

BUG=709219

Review-Url: https://codereview.chromium.org/2804913005
Cr-Commit-Position: refs/heads/master@{#463057}
Committed:
https://chromium.googlesource.com/chromium/src/+/235d2d36366b8eefb2f167de9432...
==========

[commit-bot: I haz the power, 2017-04-07 23:55:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/235d2d36366b8eefb2f167de9432...

[benwells, 2017-04-12 01:08:13]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2811073003/ by benwells@chromium.org.

The reason for reverting is: We are going with a server side fix instead for
this problem. We should still investigate separately some means of backing off
the Update Permissions prompt (e.g. with embargo)..