Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 2811063002: Enable ServiceWorkerNavigationPreload by default (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/child/runtime_features.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index f99625c399af0751799189fd6b2e6d980d2a382a..d3385d07a54cd8044213e1c943fe9f1c7920d760 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -12,7 +12,6 @@
#include "base/command_line.h"
#include "base/debug/alias.h"
-#include "base/feature_list.h"
#include "base/guid.h"
#include "base/location.h"
#include "base/macros.h"
@@ -44,7 +43,6 @@
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/common/content_client.h"
-#include "content/public/common/content_features.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/result_codes.h"
#include "net/http/http_response_headers.h"
@@ -1061,42 +1059,6 @@ void ServiceWorkerVersion::OnSimpleEventFinished(
callback.Run(status);
}
-ServiceWorkerVersion::NavigationPreloadSupportStatus
-ServiceWorkerVersion::GetNavigationPreloadSupportStatus() const {
- // The origin trial of Navigation Preload started from M57. And the worker
- // entry in the database written by Chrome (>= M56) must have the
- // origin_trial_tokens field.
- const bool has_valid_token =
- origin_trial_tokens_ &&
- base::ContainsKey(*origin_trial_tokens_,
- "ServiceWorkerNavigationPreload");
- if (!has_valid_token) {
- if (base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine(
- features::kServiceWorkerNavigationPreload.name,
- base::FeatureList::OVERRIDE_ENABLE_FEATURE)) {
- return NavigationPreloadSupportStatus::SUPPORTED;
- } else {
- return NavigationPreloadSupportStatus::
- NOT_SUPPORTED_NO_VALID_ORIGIN_TRIAL_TOKEN;
- }
- }
- if (base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine(
- features::kServiceWorkerNavigationPreload.name,
- base::FeatureList::OVERRIDE_ENABLE_FEATURE)) {
- return NavigationPreloadSupportStatus::SUPPORTED;
- }
- if (base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine(
- features::kServiceWorkerNavigationPreload.name,
- base::FeatureList::OVERRIDE_DISABLE_FEATURE)) {
- return NavigationPreloadSupportStatus::
- NOT_SUPPORTED_DISABLED_BY_COMMAND_LINE;
- }
- if (base::FeatureList::IsEnabled(features::kServiceWorkerNavigationPreload)) {
- return NavigationPreloadSupportStatus::SUPPORTED;
- }
- return NavigationPreloadSupportStatus::NOT_SUPPORTED_FIELD_TRIAL_STOPPED;
-}
-
void ServiceWorkerVersion::CountFeature(uint32_t feature) {
if (!used_features_.insert(feature).second)
return;
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/child/runtime_features.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698