Move LayoutBoxModelObject's PaintLayer member to rare paint data

Move LayoutBoxModelObject's PaintLayer member to rare paint data

This patch removes the PaintLayer member from LayoutBoxModelObject and
puts it in RarePaintData. This will save one pointer of memory and in
the common case RarePaintData will already exist.

Two minor cleanups have been included:
1) LayoutBoxModelObject::DestroyLayer has been changed to only get called
when a layer exists.
2) LayoutBoxModelObject::CreateLayer has been refactored to work more like
DestroyLayer. Instead of doing insert/remove logic in this function, the
caller is now responsible (InsertOnlyThisLayerAfterStyleChange).

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2811023002
Cr-Commit-Position: refs/heads/master@{#463888}
Committed: https://chromium.googlesource.com/chromium/src/+/782b87888ae14a5531d8c248fb2c3337dc638e04

[pdr., 2017-04-11 02:43:27]

Description was changed from

==========
Move LayoutBoxModelObject's PaintLayer member to rare paint data

This patch removes the PaintLayer member from LayoutBoxModelObject and
puts it in RarePaintData. This will save one pointer of memory and in
the common case RarePaintData will already exist.

Two minor cleanups have been included:
1) LayoutBoxModelObject::DestroyLayer has been changed to only get called
when a layer exists.
2) LayoutBoxModelObject::CreateLayer has been refactored to work more like
DestroyLayer. Instead of doing insert/remove logic in this function, the
caller is now responsible (InsertOnlyThisLayerAfterStyleChange).

BUG=700452
==========

to

==========
Move LayoutBoxModelObject's PaintLayer member to rare paint data

This patch removes the PaintLayer member from LayoutBoxModelObject and
puts it in RarePaintData. This will save one pointer of memory and in
the common case RarePaintData will already exist.

Two minor cleanups have been included:
1) LayoutBoxModelObject::DestroyLayer has been changed to only get called
when a layer exists.
2) LayoutBoxModelObject::CreateLayer has been refactored to work more like
DestroyLayer. Instead of doing insert/remove logic in this function, the
caller is now responsible (InsertOnlyThisLayerAfterStyleChange).

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2017-04-11 02:44:18]

Description was changed from

==========
Move LayoutBoxModelObject's PaintLayer member to rare paint data

This patch removes the PaintLayer member from LayoutBoxModelObject and
puts it in RarePaintData. This will save one pointer of memory and in
the common case RarePaintData will already exist.

Two minor cleanups have been included:
1) LayoutBoxModelObject::DestroyLayer has been changed to only get called
when a layer exists.
2) LayoutBoxModelObject::CreateLayer has been refactored to work more like
DestroyLayer. Instead of doing insert/remove logic in this function, the
caller is now responsible (InsertOnlyThisLayerAfterStyleChange).

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move LayoutBoxModelObject's PaintLayer member to rare paint data

This patch removes the PaintLayer member from LayoutBoxModelObject and
puts it in RarePaintData. This will save one pointer of memory and in
the common case RarePaintData will already exist.

Two minor cleanups have been included:
1) LayoutBoxModelObject::DestroyLayer has been changed to only get called
when a layer exists.
2) LayoutBoxModelObject::CreateLayer has been refactored to work more like
DestroyLayer. Instead of doing insert/remove logic in this function, the
caller is now responsible (InsertOnlyThisLayerAfterStyleChange).

BUG=700452
==========

[pdr., 2017-04-11 02:44:19]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, wangxianzhu@chromium.org

[pdr., 2017-04-11 02:44:22]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 02:44:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 04:33:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 04:33:41]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-04-11 21:52:34]

https://codereview.chromium.org/2811023002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right):

https://codereview.chromium.org/2811023002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:332:
CreateLayer();
Move 333 inside and call this CreateLayerAfterStyleChange?

https://codereview.chromium.org/2811023002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h (right):

https://codereview.chromium.org/2811023002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h:86: // An important
member of this class is PaintLayer which is stored in a rare-
nit: "PaintLayer, which"

[pdr., 2017-04-11 22:35:27]

Description was changed from

==========
Move LayoutBoxModelObject's PaintLayer member to rare paint data

This patch removes the PaintLayer member from LayoutBoxModelObject and
puts it in RarePaintData. This will save one pointer of memory and in
the common case RarePaintData will already exist.

Two minor cleanups have been included:
1) LayoutBoxModelObject::DestroyLayer has been changed to only get called
when a layer exists.
2) LayoutBoxModelObject::CreateLayer has been refactored to work more like
DestroyLayer. Instead of doing insert/remove logic in this function, the
caller is now responsible (InsertOnlyThisLayerAfterStyleChange).

BUG=700452
==========

to

==========
Move LayoutBoxModelObject's PaintLayer member to rare paint data

This patch removes the PaintLayer member from LayoutBoxModelObject and
puts it in RarePaintData. This will save one pointer of memory and in
the common case RarePaintData will already exist.

Two minor cleanups have been included:
1) LayoutBoxModelObject::DestroyLayer has been changed to only get called
when a layer exists.
2) LayoutBoxModelObject::CreateLayer has been refactored to work more like
DestroyLayer. Instead of doing insert/remove logic in this function, the
caller is now responsible (InsertOnlyThisLayerAfterStyleChange).

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2017-04-11 22:36:01]

https://codereview.chromium.org/2811023002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right):

https://codereview.chromium.org/2811023002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:332:
CreateLayer();
On 2017/04/11 at 21:52:34, chrishtr wrote:
> Move 333 inside and call this CreateLayerAfterStyleChange?

Done

https://codereview.chromium.org/2811023002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h (right):

https://codereview.chromium.org/2811023002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h:86: // An important
member of this class is PaintLayer which is stored in a rare-
On 2017/04/11 at 21:52:34, chrishtr wrote:
> nit: "PaintLayer, which"

Done

[chrishtr, 2017-04-11 22:39:06]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-04-11 22:39:06]

lgtm

[commit-bot: I haz the power, 2017-04-11 22:40:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 00:42:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 00:42:41]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)

[pdr., 2017-04-12 01:35:06]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-04-12 01:35:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 01:47:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491960906416110,
"parent_rev": "f416ef84abd82d7c45713fa69e8b44787251bf67", "commit_rev":
"782b87888ae14a5531d8c248fb2c3337dc638e04"}

[commit-bot: I haz the power, 2017-04-12 01:47:52]

Description was changed from

==========
Move LayoutBoxModelObject's PaintLayer member to rare paint data

This patch removes the PaintLayer member from LayoutBoxModelObject and
puts it in RarePaintData. This will save one pointer of memory and in
the common case RarePaintData will already exist.

Two minor cleanups have been included:
1) LayoutBoxModelObject::DestroyLayer has been changed to only get called
when a layer exists.
2) LayoutBoxModelObject::CreateLayer has been refactored to work more like
DestroyLayer. Instead of doing insert/remove logic in this function, the
caller is now responsible (InsertOnlyThisLayerAfterStyleChange).

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move LayoutBoxModelObject's PaintLayer member to rare paint data

This patch removes the PaintLayer member from LayoutBoxModelObject and
puts it in RarePaintData. This will save one pointer of memory and in
the common case RarePaintData will already exist.

Two minor cleanups have been included:
1) LayoutBoxModelObject::DestroyLayer has been changed to only get called
when a layer exists.
2) LayoutBoxModelObject::CreateLayer has been refactored to work more like
DestroyLayer. Instead of doing insert/remove logic in this function, the
caller is now responsible (InsertOnlyThisLayerAfterStyleChange).

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2811023002
Cr-Commit-Position: refs/heads/master@{#463888}
Committed:
https://chromium.googlesource.com/chromium/src/+/782b87888ae14a5531d8c248fb2c...
==========

[commit-bot: I haz the power, 2017-04-12 01:47:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/782b87888ae14a5531d8c248fb2c...