Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2811023002: Move LayoutBoxModelObject's PaintLayer member to rare paint data (Closed)
Patch Set: Minor cleanup Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 if (rare_paint_data_) 410 if (rare_paint_data_)
411 return rare_paint_data_->LocalBorderBoxProperties(); 411 return rare_paint_data_->LocalBorderBoxProperties();
412 return nullptr; 412 return nullptr;
413 } 413 }
414 414
415 // The complete set of property nodes that should be used as a starting point 415 // The complete set of property nodes that should be used as a starting point
416 // to paint contents of this LayoutObject. 416 // to paint contents of this LayoutObject.
417 PropertyTreeState ContentsProperties() const; 417 PropertyTreeState ContentsProperties() const;
418 418
419 private: 419 private:
420 RarePaintData& EnsureRarePaintData();
421 RarePaintData* GetRarePaintData() { return rare_paint_data_.get(); }
422
423 ////////////////////////////////////////// 420 //////////////////////////////////////////
424 // Helper functions. Dangerous to use! 421 // Helper functions. Dangerous to use!
425 void SetPreviousSibling(LayoutObject* previous) { previous_ = previous; } 422 void SetPreviousSibling(LayoutObject* previous) { previous_ = previous; }
426 void SetNextSibling(LayoutObject* next) { next_ = next; } 423 void SetNextSibling(LayoutObject* next) { next_ = next; }
427 void SetParent(LayoutObject* parent) { 424 void SetParent(LayoutObject* parent) {
428 parent_ = parent; 425 parent_ = parent;
429 426
430 // Only update if our flow thread state is different from our new parent and 427 // Only update if our flow thread state is different from our new parent and
431 // if we're not a LayoutFlowThread. 428 // if we're not a LayoutFlowThread.
432 // A LayoutFlowThread is always considered to be inside itself, so it never 429 // A LayoutFlowThread is always considered to be inside itself, so it never
(...skipping 1668 matching lines...) Expand 10 before | Expand all | Expand 10 after
2101 bitfields_.SetContainsInlineWithOutlineAndContinuation(b); 2098 bitfields_.SetContainsInlineWithOutlineAndContinuation(b);
2102 } 2099 }
2103 2100
2104 void SetOutlineMayBeAffectedByDescendants(bool b) { 2101 void SetOutlineMayBeAffectedByDescendants(bool b) {
2105 bitfields_.SetOutlineMayBeAffectedByDescendants(b); 2102 bitfields_.SetOutlineMayBeAffectedByDescendants(b);
2106 } 2103 }
2107 void SetPreviousOutlineMayBeAffectedByDescendants(bool b) { 2104 void SetPreviousOutlineMayBeAffectedByDescendants(bool b) {
2108 bitfields_.SetPreviousOutlineMayBeAffectedByDescendants(b); 2105 bitfields_.SetPreviousOutlineMayBeAffectedByDescendants(b);
2109 } 2106 }
2110 2107
2108 RarePaintData& EnsureRarePaintData();
2109 RarePaintData* GetRarePaintData() const { return rare_paint_data_.get(); }
2110
2111 private: 2111 private:
2112 // Used only by applyFirstLineChanges to get a first line style based off of a 2112 // Used only by applyFirstLineChanges to get a first line style based off of a
2113 // given new style, without accessing the cache. 2113 // given new style, without accessing the cache.
2114 PassRefPtr<ComputedStyle> UncachedFirstLineStyle() const; 2114 PassRefPtr<ComputedStyle> UncachedFirstLineStyle() const;
2115 2115
2116 // Adjusts a visual rect in the space of |m_visualRect| to be in the 2116 // Adjusts a visual rect in the space of |m_visualRect| to be in the
2117 // space of the |paintInvalidationContainer|, if needed. They can be different 2117 // space of the |paintInvalidationContainer|, if needed. They can be different
2118 // only if |paintInvalidationContainer| is a composited scroller. 2118 // only if |paintInvalidationContainer| is a composited scroller.
2119 void AdjustVisualRectForCompositedScrolling( 2119 void AdjustVisualRectForCompositedScrolling(
2120 LayoutRect&, 2120 LayoutRect&,
(...skipping 702 matching lines...) Expand 10 before | Expand all | Expand 10 after
2823 CORE_EXPORT void showLineTree(const blink::LayoutObject*); 2823 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
2824 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1); 2824 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
2825 // We don't make object2 an optional parameter so that showLayoutTree 2825 // We don't make object2 an optional parameter so that showLayoutTree
2826 // can be called from gdb easily. 2826 // can be called from gdb easily.
2827 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1, 2827 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
2828 const blink::LayoutObject* object2); 2828 const blink::LayoutObject* object2);
2829 2829
2830 #endif 2830 #endif
2831 2831
2832 #endif // LayoutObject_h 2832 #endif // LayoutObject_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/paint/RarePaintData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698