VR: Add stub WebVR warnings.

VR: Add stub WebVR warnings.

This CL adds properly-positioned elements for the permanent and transient WebVR
warning. The elements are currently invisible, and will be made visible when
Skia rendering supplies their texture and exact size.

BUG=710150
Review-Url: https://codereview.chromium.org/2810963003
Cr-Commit-Position: refs/heads/master@{#464135}
Committed: https://chromium.googlesource.com/chromium/src/+/a332bf72eded671758da727bf530313696128ad3

[cjgrant, 2017-04-11 20:04:18]

cjgrant@chromium.org changed reviewers:
+ acondor@google.com, mthiesse@chromium.org

[acondor_, 2017-04-11 21:01:17]

https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:56: element->fill =
vr_shell::Fill::NONE;
What about a new Fill type for the Skia texture?

[cjgrant, 2017-04-11 21:05:37]

https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:56: element->fill =
vr_shell::Fill::NONE;
On 2017/04/11 21:01:17, acondor wrote:
> What about a new Fill type for the Skia texture?

Possibly, but if it did, that would come with your CL, along with the code to
interpret the type.  IMO.

[cjgrant, 2017-04-11 21:05:38]

https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:56: element->fill =
vr_shell::Fill::NONE;
On 2017/04/11 21:01:17, acondor wrote:
> What about a new Fill type for the Skia texture?

Possibly, but if it did, that would come with your CL, along with the code to
interpret the type.  IMO.

[mthiesse, 2017-04-11 22:26:23]

lgtm

[acondor_, 2017-04-11 23:06:05]

sgtm & lgtm :)

[cjgrant, 2017-04-12 18:12:03]

The CQ bit was checked by cjgrant@chromium.org

[commit-bot: I haz the power, 2017-04-12 18:13:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:34:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492020723228440,
"parent_rev": "2b0f0765add212a66e9b80928278abf473f2acb3", "commit_rev":
"a332bf72eded671758da727bf530313696128ad3"}

[commit-bot: I haz the power, 2017-04-12 20:35:44]

Description was changed from

==========
VR: Add stub WebVR warnings.

This CL adds properly-positioned elements for the permanent and transient WebVR
warning. The elements are currently invisible, and will be made visible when
Skia rendering supplies their texture and exact size.

BUG=710150
==========

to

==========
VR: Add stub WebVR warnings.

This CL adds properly-positioned elements for the permanent and transient WebVR
warning. The elements are currently invisible, and will be made visible when
Skia rendering supplies their texture and exact size.

BUG=710150

Review-Url: https://codereview.chromium.org/2810963003
Cr-Commit-Position: refs/heads/master@{#464135}
Committed:
https://chromium.googlesource.com/chromium/src/+/a332bf72eded671758da727bf530...
==========

[commit-bot: I haz the power, 2017-04-12 20:35:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a332bf72eded671758da727bf530...