Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2810963003: VR: Add stub WebVR warnings. (Closed)

Created:
3 years, 8 months ago by cjgrant
Modified:
3 years, 8 months ago
Reviewers:
acondor_, mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Add stub WebVR warnings. This CL adds properly-positioned elements for the permanent and transient WebVR warning. The elements are currently invisible, and will be made visible when Skia rendering supplies their texture and exact size. BUG=710150 Review-Url: https://codereview.chromium.org/2810963003 Cr-Commit-Position: refs/heads/master@{#464135} Committed: https://chromium.googlesource.com/chromium/src/+/a332bf72eded671758da727bf530313696128ad3

Patch Set 1 #

Patch Set 2 : Add a comment. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -13 lines) Patch
M chrome/browser/android/vr_shell/ui_scene_manager.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 2 chunks +64 lines, -13 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
cjgrant
3 years, 8 months ago (2017-04-11 20:04:18 UTC) #2
acondor_
https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/vr_shell/ui_scene_manager.cc File chrome/browser/android/vr_shell/ui_scene_manager.cc (right): https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/vr_shell/ui_scene_manager.cc#newcode56 chrome/browser/android/vr_shell/ui_scene_manager.cc:56: element->fill = vr_shell::Fill::NONE; What about a new Fill type ...
3 years, 8 months ago (2017-04-11 21:01:17 UTC) #3
cjgrant
https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/vr_shell/ui_scene_manager.cc File chrome/browser/android/vr_shell/ui_scene_manager.cc (right): https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/vr_shell/ui_scene_manager.cc#newcode56 chrome/browser/android/vr_shell/ui_scene_manager.cc:56: element->fill = vr_shell::Fill::NONE; On 2017/04/11 21:01:17, acondor wrote: > ...
3 years, 8 months ago (2017-04-11 21:05:37 UTC) #4
cjgrant
https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/vr_shell/ui_scene_manager.cc File chrome/browser/android/vr_shell/ui_scene_manager.cc (right): https://codereview.chromium.org/2810963003/diff/20001/chrome/browser/android/vr_shell/ui_scene_manager.cc#newcode56 chrome/browser/android/vr_shell/ui_scene_manager.cc:56: element->fill = vr_shell::Fill::NONE; On 2017/04/11 21:01:17, acondor wrote: > ...
3 years, 8 months ago (2017-04-11 21:05:38 UTC) #5
mthiesse
lgtm
3 years, 8 months ago (2017-04-11 22:26:23 UTC) #6
acondor_
sgtm & lgtm :)
3 years, 8 months ago (2017-04-11 23:06:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810963003/20001
3 years, 8 months ago (2017-04-12 18:13:00 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 20:35:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a332bf72eded671758da727bf530...

Powered by Google App Engine
This is Rietveld 408576698