Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2810913006: [Suggestions] Remove access point to dedicated pref screen (Closed)

Created:
3 years, 8 months ago by dgn
Modified:
3 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Suggestions] Remove access point to dedicated pref screen BUG=706384, 710636 Review-Url: https://codereview.chromium.org/2810913006 Cr-Commit-Position: refs/heads/master@{#464030} Committed: https://chromium.googlesource.com/chromium/src/+/49766ea841fd7c75647e4ffb0659dc344d8d8947

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M chrome/android/java/res/xml/main_preferences.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dgn
PTAL
3 years, 8 months ago (2017-04-11 22:46:04 UTC) #4
Bernhard Bauer
lgtm https://codereview.chromium.org/2810913006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java (right): https://codereview.chromium.org/2810913006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java#newcode33 chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java:33: * TODO(https://crbug.com/710636): Remove when the suggestions preference design ...
3 years, 8 months ago (2017-04-11 23:10:04 UTC) #7
dgn
Thanks! https://codereview.chromium.org/2810913006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java (right): https://codereview.chromium.org/2810913006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java#newcode33 chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java:33: * TODO(https://crbug.com/710636): Remove when the suggestions preference design ...
3 years, 8 months ago (2017-04-12 14:41:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810913006/20001
3 years, 8 months ago (2017-04-12 14:41:29 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 15:21:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/49766ea841fd7c75647e4ffb0659...

Powered by Google App Engine
This is Rietveld 408576698