chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java - Issue 2810913006: [Suggestions] Remove access point to dedicated pref screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

Issue 2810913006: [Suggestions] Remove access point to dedicated pref screen (Closed)

Patch Set: address comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/xml/main_preferences.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/ContentSuggestionsPreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

index f5847694243472280dfe4ae4e9648bf5bfce4f36..d21472a63ef2ab39a03792d14bce3a8b44f03197 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

@@ -21,7 +21,6 @@ import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

import org.chromium.base.library_loader.LibraryLoader;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

@@ -31,7 +30,6 @@ import org.chromium.chrome.browser.notifications.NotificationConstants;

import org.chromium.chrome.browser.notifications.NotificationUmaTracker;

import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsNotificationAction;

import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsNotificationOptOut;

-import org.chromium.chrome.browser.preferences.ContentSuggestionsPreferences;

import java.util.Collection;

import java.util.Collections;

@@ -186,14 +184,6 @@ public class ContentSuggestionsNotificationHelper {

.setPriority(priority)

.setLargeIcon(image)

.setSmallIcon(R.drawable.ic_chrome);

- if (ChromeFeatureList.isEnabled(ChromeFeatureList.CONTENT_SUGGESTIONS_SETTINGS)) {

- PendingIntent settingsIntent = PendingIntent.getActivity(context, 0,

- ContentSuggestionsPreferences.createLaunchIntent(

- context, ContentSuggestionsPreferences.LAUNCH_SOURCE_NOTIFICATION),

- 0);

- builder.addAction(R.drawable.settings_cog, context.getString(R.string.preferences),

- settingsIntent);

- }

if (priority >= 0) {

builder.setDefaults(Notification.DEFAULT_ALL);

}