[scheduler] Remove webthread_impl_for_worker_scheduler from public API.

[scheduler] Remove webthread_impl_for_worker_scheduler from public API.

As a first step of simplification of public/platform/scheduler, do not
expose WebThreadImplForWorkerScheduler to content/ and use
WebThreadBase::Create{Worker,Compositor}Thread instead.

R=skyostil@chromium.org,alexclarke@chromium.org,kinuko@chromium.org
BUG=710063
Review-Url: https://codereview.chromium.org/2810883002
Cr-Commit-Position: refs/heads/master@{#463620}
Committed: https://chromium.googlesource.com/chromium/src/+/c7369bf0679442fa79338ab4502ef836b2244c03

[altimin, 2017-04-10 19:15:59]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 19:16:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2017-04-10 19:20:43]

PTAL

[commit-bot: I haz the power, 2017-04-10 21:03:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 21:03:32]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Sami, 2017-04-11 10:03:10]

https://codereview.chromium.org/2810883002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/scheduler/child/webthread_base.h
(right):

https://codereview.chromium.org/2810883002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/scheduler/child/webthread_base.h:25: static
std::unique_ptr<WebThreadBase> CreateWorkerThread(
Could we put these in WebThread instead and make WebThreadBase non-public? It's
really just meant to be a common base class for the different thread types
instead something that content/ should depend on.

[altimin, 2017-04-11 10:44:35]

https://codereview.chromium.org/2810883002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/scheduler/child/webthread_base.h
(right):

https://codereview.chromium.org/2810883002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/scheduler/child/webthread_base.h:25: static
std::unique_ptr<WebThreadBase> CreateWorkerThread(
On 2017/04/11 10:03:10, Sami wrote:
> Could we put these in WebThread instead and make WebThreadBase non-public?
It's
> really just meant to be a common base class for the different thread types
> instead something that content/ should depend on.

There's a problem with WebThreadBase::Init method. I'll try to get rid of it,
but let's make one step at a time. I heard you liked small patches.

[Sami, 2017-04-11 11:46:29]

lgtm.

https://codereview.chromium.org/2810883002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/scheduler/child/webthread_base.h
(right):

https://codereview.chromium.org/2810883002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/scheduler/child/webthread_base.h:25: static
std::unique_ptr<WebThreadBase> CreateWorkerThread(
On 2017/04/11 10:44:35, altimin wrote:
> On 2017/04/11 10:03:10, Sami wrote:
> > Could we put these in WebThread instead and make WebThreadBase non-public?
> It's
> > really just meant to be a common base class for the different thread types
> > instead something that content/ should depend on.
> 
> There's a problem with WebThreadBase::Init method. I'll try to get rid of it,
> but let's make one step at a time. I heard you liked small patches.

I don't believe I was told anything I say can be used against me :) But fair
enough, mind leaving a TODO at the top of this class?

[altimin, 2017-04-11 11:52:45]

altimin@chromium.org changed reviewers:
+ jochen@chromium.org

[altimin, 2017-04-11 11:52:45]

+jochen@ for content/ changes

[jochen (gone - plz use gerrit), 2017-04-11 11:54:00]

content lgtm

[kinuko, 2017-04-11 12:17:03]

lgtm

[altimin, 2017-04-11 12:39:56]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 12:40:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 14:21:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 14:21:01]

Dry run: This issue passed the CQ dry run.

[altimin, 2017-04-11 14:21:34]

The CQ bit was checked by altimin@chromium.org

[altimin, 2017-04-11 14:21:34]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
jochen@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2810883002/#ps20001
(title: "Add TODO to remove WebThreadBase from public API")

[commit-bot: I haz the power, 2017-04-11 14:22:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 14:29:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491920494385830,
"parent_rev": "7e0b9a9cdf69d9175d41ad5338c185daf88660ae", "commit_rev":
"c7369bf0679442fa79338ab4502ef836b2244c03"}

[commit-bot: I haz the power, 2017-04-11 14:30:17]

Description was changed from

==========
[scheduler] Remove webthread_impl_for_worker_scheduler from public API.

As a first step of simplification of public/platform/scheduler, do not
expose WebThreadImplForWorkerScheduler to content/ and use
WebThreadBase::Create{Worker,Compositor}Thread instead.

R=skyostil@chromium.org,alexclarke@chromium.org,kinuko@chromium.org
BUG=710063
==========

to

==========
[scheduler] Remove webthread_impl_for_worker_scheduler from public API.

As a first step of simplification of public/platform/scheduler, do not
expose WebThreadImplForWorkerScheduler to content/ and use
WebThreadBase::Create{Worker,Compositor}Thread instead.

R=skyostil@chromium.org,alexclarke@chromium.org,kinuko@chromium.org
BUG=710063

Review-Url: https://codereview.chromium.org/2810883002
Cr-Commit-Position: refs/heads/master@{#463620}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7369bf0679442fa79338ab4502e...
==========

[commit-bot: I haz the power, 2017-04-11 14:30:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c7369bf0679442fa79338ab4502e...