[scheduler] Remove webthread_impl_for_worker_scheduler from public API.

third_party/WebKit/public/platform/scheduler/child/webthread_base.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef THIRD_PARTY_WEBKIT_PUBLIC_PLATFORM_SCHEDULER_CHILD_WEBTHREAD_BASE_H_
 #define THIRD_PARTY_WEBKIT_PUBLIC_PLATFORM_SCHEDULER_CHILD_WEBTHREAD_BASE_H_
 
 #include <map>
 #include <memory>
 
 #include "base/threading/thread.h"
 #include "public/platform/WebCommon.h"
 #include "public/platform/WebThread.h"
 #include "public/platform/WebTraceLocation.h"
 
 namespace blink {
 namespace scheduler {
 class SingleThreadIdleTaskRunner;
 class TaskTimeObserver;
 
 class BLINK_PLATFORM_EXPORT WebThreadBase : public WebThread {
  public:
   ~WebThreadBase() override;
 
+  static std::unique_ptr<WebThreadBase> CreateWorkerThread(

[Sami, 2017/04/11 10:03:10]

Could we put these in WebThread instead and make WebThreadBase non-public? It's
really just meant to be a common base class for the different thread types
instead something that content/ should depend on.

[altimin, 2017/04/11 10:44:35]

There's a problem with WebThreadBase::Init method. I'll try to get rid of it,
but let's make one step at a time. I heard you liked small patches.

[Sami, 2017/04/11 11:46:28]

I don't believe I was told anything I say can be used against me :) But fair
enough, mind leaving a TODO at the top of this class?

+      const char* name,
+      base::Thread::Options options);
+  static std::unique_ptr<WebThreadBase> CreateCompositorThread(
+      base::Thread::Options options);
+
   // WebThread implementation.
   bool IsCurrentThread() const override;
   PlatformThreadId ThreadId() const override = 0;
 
   virtual void PostIdleTask(const WebTraceLocation& location,
                             IdleTask* idle_task);
 
   void AddTaskObserver(TaskObserver* observer) override;
   void RemoveTaskObserver(TaskObserver* observer) override;
 
   void AddTaskTimeObserver(TaskTimeObserver* task_time_observer) override;
   void RemoveTaskTimeObserver(TaskTimeObserver* task_time_observer) override;
 
   // Returns the base::Bind-compatible task runner for posting tasks to this
   // thread. Can be called from any thread.
   virtual base::SingleThreadTaskRunner* GetTaskRunner() const = 0;
 
   // Returns the base::Bind-compatible task runner for posting idle tasks to
   // this thread. Can be called from any thread.
   virtual scheduler::SingleThreadIdleTaskRunner* GetIdleTaskRunner() const = 0;
 
+  virtual void Init() = 0;
+
  protected:
   class TaskObserverAdapter;
 
   WebThreadBase();
 
   virtual void AddTaskObserverInternal(
       base::MessageLoop::TaskObserver* observer);
   virtual void RemoveTaskObserverInternal(
       base::MessageLoop::TaskObserver* observer);
 
   virtual void AddTaskTimeObserverInternal(TaskTimeObserver*) {}
   virtual void RemoveTaskTimeObserverInternal(TaskTimeObserver*) {}
 
   static void RunWebThreadIdleTask(
       std::unique_ptr<WebThread::IdleTask> idle_task,
       base::TimeTicks deadline);
 
  private:
   typedef std::map<TaskObserver*, TaskObserverAdapter*> TaskObserverMap;
   TaskObserverMap task_observer_map_;
 };
 
 }  // namespace scheduler
 }  // namespace blink
 
 #endif  // THIRD_PARTY_WEBKIT_PUBLIC_PLATFORM_SCHEDULER_CHILD_WEBTHREAD_BASE_H_