[LargeIconService] Store downloaded icons under original URL

[LargeIconService] Store downloaded icons under original URL

This CL implements a TODO to use the original URL of the favicon
downloaded from the Google server as the key in the database.

BUG=644102
Review-Url: https://codereview.chromium.org/2810733002
Cr-Commit-Position: refs/heads/master@{#463348}
Committed: https://chromium.googlesource.com/chromium/src/+/e58f7fce980c4231c7b6af6ddd235a693b0eb566

[jkrcal, 2017-04-10 13:55:08]

jkrcal@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[jkrcal, 2017-04-10 13:55:08]

Peter, could you PTAL?

[pkotwicz, 2017-04-10 15:12:43]

LGTM

https://codereview.chromium.org/2810733002/diff/1/components/favicon/core/lar...
File components/favicon/core/large_icon_service.cc (right):

https://codereview.chromium.org/2810733002/diff/1/components/favicon/core/lar...
components/favicon/core/large_icon_service.cc:224: const std::string& icon_url,
Maybe rename |icon_url| to |server_request_url| here and in the caller?

[jkrcal, 2017-04-10 15:51:00]

Thanks!

https://codereview.chromium.org/2810733002/diff/1/components/favicon/core/lar...
File components/favicon/core/large_icon_service.cc (right):

https://codereview.chromium.org/2810733002/diff/1/components/favicon/core/lar...
components/favicon/core/large_icon_service.cc:224: const std::string& icon_url,
On 2017/04/10 15:12:42, pkotwicz wrote:
> Maybe rename |icon_url| to |server_request_url| here and in the caller?

Done.

[jkrcal, 2017-04-10 16:37:46]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 16:38:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 17:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:27:12]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2017-04-10 18:57:53]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2017-04-10 18:57:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/2810733002/#ps20001
(title: "Peter's comments")

[commit-bot: I haz the power, 2017-04-10 18:58:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 19:08:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491850673531290,
"parent_rev": "11eb9bf9995543cd1ff691dfa76303dc626e967a", "commit_rev":
"e58f7fce980c4231c7b6af6ddd235a693b0eb566"}

[commit-bot: I haz the power, 2017-04-10 19:09:42]

Description was changed from

==========
[LargeIconService] Store downloaded icons under original URL

This CL implements a TODO to use the original URL of the favicon
downloaded from the Google server as the key in the database.

BUG=644102
==========

to

==========
[LargeIconService] Store downloaded icons under original URL

This CL implements a TODO to use the original URL of the favicon
downloaded from the Google server as the key in the database.

BUG=644102

Review-Url: https://codereview.chromium.org/2810733002
Cr-Commit-Position: refs/heads/master@{#463348}
Committed:
https://chromium.googlesource.com/chromium/src/+/e58f7fce980c4231c7b6af6ddd23...
==========

[commit-bot: I haz the power, 2017-04-10 19:09:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e58f7fce980c4231c7b6af6ddd23...