Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2807143002: [Image fetcher] Add Content-Location header to image_fetcher::RequestMetadata (Closed)

Created:
3 years, 8 months ago by jkrcal
Modified:
3 years, 8 months ago
Reviewers:
markusheintz_
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Image fetcher] Add Content-Location header to image_fetcher::RequestMetadata Previous CL (2793983002) added a pointer to net::HttpResponseHeaders into image_fetcher::RequestMetadata. This was flawed because the object got deleted before the callback to ImageFetcher was called. A solution would be to create a copy of the headers object from its raw_headers() content. This seems too heavy for a corner-use case needing one header. As a solution, this CL removes the what has been added by the previous CL and adds a new struct field for this particular use case. BUG=644102 Review-Url: https://codereview.chromium.org/2807143002 Cr-Commit-Position: refs/heads/master@{#463260} Committed: https://chromium.googlesource.com/chromium/src/+/fe52c7f885b342a38e4351317b63f56982cb8955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -45 lines) Patch
M components/image_fetcher/core/image_data_fetcher.cc View 2 chunks +10 lines, -1 line 0 comments Download
M components/image_fetcher/core/image_data_fetcher_unittest.cc View 6 chunks +46 lines, -17 lines 0 comments Download
M components/image_fetcher/core/request_metadata.h View 1 chunk +1 line, -6 lines 0 comments Download
M components/image_fetcher/core/request_metadata.cc View 1 chunk +2 lines, -21 lines 0 comments Download
M components/image_fetcher/core/request_metadata_unittest.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
jkrcal
Markus, could you PTAL?
3 years, 8 months ago (2017-04-10 13:26:06 UTC) #4
markusheintz_
On 2017/04/10 13:26:06, jkrcal wrote: > Markus, could you PTAL? LGTM
3 years, 8 months ago (2017-04-10 13:47:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807143002/1
3 years, 8 months ago (2017-04-10 14:33:03 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 14:38:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe52c7f885b342a38e4351317b63...

Powered by Google App Engine
This is Rietveld 408576698