Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2810663002:
Reland: Improve unit tests for OnQueueNextWakeUpChanged (Closed)
|
Created:
3 years, 8 months ago by alex clarke (OOO till 29th) Modified:
3 years, 8 months ago CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionImprove unit tests for OnQueueNextWakeUpChanged
BUG=
Review-Url: https://codereview.chromium.org/2810663002
Cr-Original-Commit-Position: refs/heads/master@{#463247}
Committed: https://chromium.googlesource.com/chromium/src/+/e206dbe248c7727f81424d6b89274a52def52e6a
Review-Url: https://codereview.chromium.org/2810663002
Cr-Commit-Position: refs/heads/master@{#464392}
Committed: https://chromium.googlesource.com/chromium/src/+/a356ba7b790ece519e5d162a80813505d5f62449
Patch Set 1 #Patch Set 2 : Rebased #Messages
Total messages: 29 (18 generated)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
alexclarke@chromium.org changed reviewers: + skyostil@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Improve unit tests for OnQueueNextWakeUpChanged BUG= ========== to ========== Improve unit tests for OnQueueNextWakeUpChanged BUG= ==========
skyostil@chromium.org changed reviewers: + altimin@chromium.org
lgtm, +altimin@ FYI
On 2017/04/10 12:54:42, Sami wrote: > lgtm, +altimin@ FYI thanks, lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by alexclarke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491831590151180, "parent_rev":
"a0364a2865e00032fc00d2619371e4975ebdbcf5", "commit_rev":
"e206dbe248c7727f81424d6b89274a52def52e6a"}
Message was sent while issue was closed.
Description was changed from ========== Improve unit tests for OnQueueNextWakeUpChanged BUG= ========== to ========== Improve unit tests for OnQueueNextWakeUpChanged BUG= Review-Url: https://codereview.chromium.org/2810663002 Cr-Commit-Position: refs/heads/master@{#463247} Committed: https://chromium.googlesource.com/chromium/src/+/e206dbe248c7727f81424d6b8927... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e206dbe248c7727f81424d6b8927...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2810683003/ by robliao@chromium.org. The reason for reverting is: Revert of https://codereview.chromium.org/2798563003 will invalidate this patchset..
Message was sent while issue was closed.
On 2017/04/10 21:18:38, robliao wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2810683003/ by mailto:robliao@chromium.org. > > The reason for reverting is: Revert of > https://codereview.chromium.org/2798563003 will invalidate this patchset.. I believe that we can reland it now.
Message was sent while issue was closed.
Description was changed from ========== Improve unit tests for OnQueueNextWakeUpChanged BUG= Review-Url: https://codereview.chromium.org/2810663002 Cr-Commit-Position: refs/heads/master@{#463247} Committed: https://chromium.googlesource.com/chromium/src/+/e206dbe248c7727f81424d6b8927... ========== to ========== Improve unit tests for OnQueueNextWakeUpChanged BUG= Review-Url: https://codereview.chromium.org/2810663002 Cr-Commit-Position: refs/heads/master@{#463247} Committed: https://chromium.googlesource.com/chromium/src/+/e206dbe248c7727f81424d6b8927... ==========
The CQ bit was checked by alexclarke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by alexclarke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org, altimin@chromium.org Link to the patchset: https://codereview.chromium.org/2810663002/#ps20001 (title: "Rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492086342908170,
"parent_rev": "d0dbccf1f8d23dfa32defdd02c0a3df990729358", "commit_rev":
"a356ba7b790ece519e5d162a80813505d5f62449"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492086342908170,
"parent_rev": "d0dbccf1f8d23dfa32defdd02c0a3df990729358", "commit_rev":
"a356ba7b790ece519e5d162a80813505d5f62449"}
Message was sent while issue was closed.
Description was changed from ========== Improve unit tests for OnQueueNextWakeUpChanged BUG= Review-Url: https://codereview.chromium.org/2810663002 Cr-Commit-Position: refs/heads/master@{#463247} Committed: https://chromium.googlesource.com/chromium/src/+/e206dbe248c7727f81424d6b8927... ========== to ========== Improve unit tests for OnQueueNextWakeUpChanged BUG= Review-Url: https://codereview.chromium.org/2810663002 Cr-Original-Commit-Position: refs/heads/master@{#463247} Committed: https://chromium.googlesource.com/chromium/src/+/e206dbe248c7727f81424d6b8927... Review-Url: https://codereview.chromium.org/2810663002 Cr-Commit-Position: refs/heads/master@{#464392} Committed: https://chromium.googlesource.com/chromium/src/+/a356ba7b790ece519e5d162a8081... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a356ba7b790ece519e5d162a8081... |
