Add a host parameter to ObjectVisitor methods.

Add a host parameter to ObjectVisitor methods.

This makes an ObjectVisitor as powerful as a StaticVisitor and allows
slots recording in ObjectVisitor.

This patch also renames VisitCell method of ObjectVisitor to
VisitCellPointer, so that VisitCell is free to be used for actually
visiting a cell.

BUG=chromium:709075
Review-Url: https://codereview.chromium.org/2810653002
Cr-Commit-Position: refs/heads/master@{#44860}
Committed: https://chromium.googlesource.com/v8/v8/+/c59f78f611280240d65ab74a8874ce51161bfcd2

[ulan, 2017-04-10 10:59:37]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org, mlippautz@chromium.org

[ulan, 2017-04-10 10:59:38]

ptal

https://codereview.chromium.org/2810653002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2810653002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1756:
collector->code_flusher()->VisitListHeads(&root_scavenge_visitor);
This is the only non-mechanical change:
we first visit the list heads using the root visitor and the scavenge JSFunction
slots using the static scavenging visitor.

[ulan, 2017-04-10 14:30:43]

Description was changed from

==========
Add a host parameter to ObjectVisitor methods.

This makes an ObjectVisitor as powerful as a StaticVisitor and allows
slots recording in ObjectVisitor.

BUG=chromium:709075
==========

to

==========
Add a host parameter to ObjectVisitor methods.

This makes an ObjectVisitor as powerful as a StaticVisitor and allows
slots recording in ObjectVisitor.

This patch also renames VisitCell method of ObjectVisitor to
VisitCellPointer, so that VisitCell is free to be used for actually
visiting a cell.

BUG=chromium:709075
==========

[Michael Lippautz, 2017-04-20 09:05:50]

lgtm

turns out this is also required (or at least highly beneficial) for the minor
mc, as it needs to record slots based on the host objects marking state

[Hannes Payer (out of office), 2017-04-21 09:50:09]

lgtm

[ulan, 2017-04-25 11:52:34]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 11:52:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 12:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 12:21:56]

Dry run: This issue passed the CQ dry run.

[ulan, 2017-04-25 13:36:37]

The CQ bit was checked by ulan@chromium.org

[ulan, 2017-04-25 13:36:37]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2810653002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-25 13:36:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 13:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 13:39:12]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/39766)

[ulan, 2017-04-25 13:43:24]

ulan@chromium.org changed reviewers:
+ vogelheim@chromium.org

[ulan, 2017-04-25 13:43:25]

+ vogelheim@ for snapshot changes

[vogelheim, 2017-04-25 13:53:38]

lgtm for src/snapshot/*

[ulan, 2017-04-25 14:01:24]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2017-04-25 14:01:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 14:18:53]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493128884075200,
"parent_rev": "a489abe846bb071b880c854290356af0cc521baf", "commit_rev":
"26951012a0708bad90576f25edca30bc12699898"}

[commit-bot: I haz the power, 2017-04-25 14:19:01]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493128884075200,
"parent_rev": "ef99f6667d7c0b5192a25881d0047fc6f620ce6e", "commit_rev":
"c59f78f611280240d65ab74a8874ce51161bfcd2"}

[commit-bot: I haz the power, 2017-04-25 14:19:06]

Description was changed from

==========
Add a host parameter to ObjectVisitor methods.

This makes an ObjectVisitor as powerful as a StaticVisitor and allows
slots recording in ObjectVisitor.

This patch also renames VisitCell method of ObjectVisitor to
VisitCellPointer, so that VisitCell is free to be used for actually
visiting a cell.

BUG=chromium:709075
==========

to

==========
Add a host parameter to ObjectVisitor methods.

This makes an ObjectVisitor as powerful as a StaticVisitor and allows
slots recording in ObjectVisitor.

This patch also renames VisitCell method of ObjectVisitor to
VisitCellPointer, so that VisitCell is free to be used for actually
visiting a cell.

BUG=chromium:709075

Review-Url: https://codereview.chromium.org/2810653002
Cr-Commit-Position: refs/heads/master@{#44860}
Committed:
https://chromium.googlesource.com/v8/v8/+/c59f78f611280240d65ab74a8874ce51161...
==========

[commit-bot: I haz the power, 2017-04-25 14:19:08]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/c59f78f611280240d65ab74a8874ce51161...