[heap] Introduce HeapVisitor interface.

[heap] Introduce HeapVisitor interface.

HeapVisitor is similar to StaticVisitor but uses virtual dispatch
instead of static function table. It is intended as replacement
of StaticVisitor using the CRTP.

This CL also changes the concurrent marker to use the HeapVisitor.

BUG=chromium:709075
Review-Url: https://codereview.chromium.org/2808093003
Cr-Commit-Position: refs/heads/master@{#44948}
Committed: https://chromium.googlesource.com/v8/v8/+/8ff8d674d316f8701b1685eee7f759f3b37cb54b

[ulan, 2017-04-10 17:16:38]

Description was changed from

==========
[heap] Introduce HeapVisitor interface.

HeapVisitor is a counterpart of StaticVisitor without static table.

BUG=chromium:709075
==========

to

==========
[heap] Introduce HeapVisitor interface.

HeapVisitor is similar to StaticVisitor but uses virtual dispatch
instead of static function table. It is intended as replacement
of StaticVisitor using the CRTP.

This CL also changes the concurrent marker to use the HeapVisitor.

BUG=chromium:709075
==========

[ulan, 2017-04-10 17:18:28]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org, mlippautz@chromium.org

[ulan, 2017-04-10 17:18:29]

ptal

[ulan, 2017-04-27 09:27:30]

Friendly ping :)

[ulan, 2017-04-27 11:09:52]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 11:10:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 11:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 11:13:53]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/26642)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[ulan, 2017-04-27 12:56:44]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 12:56:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2017-04-27 13:11:36]

lgtm

[commit-bot: I haz the power, 2017-04-27 13:23:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 13:23:51]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2017-04-27 14:29:50]

lgtm

https://codereview.chromium.org/2808093003/diff/100001/src/heap/objects-visit...
File src/heap/objects-visiting.h (right):

https://codereview.chromium.org/2808093003/diff/100001/src/heap/objects-visit...
src/heap/objects-visiting.h:410: virtual ResultType VisitFreeSpace(Map* map,
FreeSpace* object);
Why can FreeSpace not be part of TYPED_VISITOR_ID_LIST?

https://codereview.chromium.org/2808093003/diff/100001/src/heap/objects-visit...
src/heap/objects-visiting.h:411: };
What would it take to generate all of them automatically?

[ulan, 2017-04-27 14:59:49]

https://codereview.chromium.org/2808093003/diff/100001/src/heap/objects-visit...
File src/heap/objects-visiting.h (right):

https://codereview.chromium.org/2808093003/diff/100001/src/heap/objects-visit...
src/heap/objects-visiting.h:410: virtual ResultType VisitFreeSpace(Map* map,
FreeSpace* object);
On 2017/04/27 14:29:50, Hannes Payer wrote:
> Why can FreeSpace not be part of TYPED_VISITOR_ID_LIST?

That would require FreeSpace::BodyDescriptor, which would make it look like a
real object. It seemed better to have custom handling of FreeSpace, but I can
define empty BodyDescriptor.

https://codereview.chromium.org/2808093003/diff/100001/src/heap/objects-visit...
src/heap/objects-visiting.h:411: };
On 2017/04/27 14:29:50, Hannes Payer wrote:
> What would it take to generate all of them automatically?
We would need the corresponding classes with BodyDescriptors, e.g. class
ShortcutCandidate {}, class JSObjectFast {}.
I think these classes will be confusing because they are based on run-time
properties like shortcut-ability.

[ulan, 2017-04-27 15:42:09]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2017-04-27 15:42:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 15:43:55]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493307729313230,
"parent_rev": "0f82f0d3a4a761a944bb4f5a4153ea2f062c0269", "commit_rev":
"8ff8d674d316f8701b1685eee7f759f3b37cb54b"}

[commit-bot: I haz the power, 2017-04-27 15:44:05]

Description was changed from

==========
[heap] Introduce HeapVisitor interface.

HeapVisitor is similar to StaticVisitor but uses virtual dispatch
instead of static function table. It is intended as replacement
of StaticVisitor using the CRTP.

This CL also changes the concurrent marker to use the HeapVisitor.

BUG=chromium:709075
==========

to

==========
[heap] Introduce HeapVisitor interface.

HeapVisitor is similar to StaticVisitor but uses virtual dispatch
instead of static function table. It is intended as replacement
of StaticVisitor using the CRTP.

This CL also changes the concurrent marker to use the HeapVisitor.

BUG=chromium:709075

Review-Url: https://codereview.chromium.org/2808093003
Cr-Commit-Position: refs/heads/master@{#44948}
Committed:
https://chromium.googlesource.com/v8/v8/+/8ff8d674d316f8701b1685eee7f759f3b37...
==========

[commit-bot: I haz the power, 2017-04-27 15:44:06]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/8ff8d674d316f8701b1685eee7f759f3b37...