Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2810643002: Revert of Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9 (Closed)

Created:
3 years, 8 months ago by Mike West
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9 (patchset #3 id:40001 of https://codereview.chromium.org/2786013002/ ) Reason for revert: Many CSS layout test failures, starting in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/25380. I'm guessing that rolling FreeType in https://codereview.chromium.org/2786013002/ might have caused these differences, as it's the only patch in the diff that looks relevant (and because the CQ didn't run layout tests, which is unfortunate: not sure who's responsible for the `analyze` step?). BUG=709918 Original issue's description: > Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9 > > https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/66725768cdf758..5a3490e054bda8 > > Addresses Clang on Windows LLP64 build failure. > > BUG=706725 > > Review-Url: https://codereview.chromium.org/2786013002 > Cr-Commit-Position: refs/heads/master@{#463187} > Committed: https://chromium.googlesource.com/chromium/src/+/395ac4809e4a98b8745753caf2f3f9015b3ca1f1 TBR=bungeman@chromium.org,drott@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=706725 Review-Url: https://codereview.chromium.org/2810643002 Cr-Commit-Position: refs/heads/master@{#463202} Committed: https://chromium.googlesource.com/chromium/src/+/66ba5e7e910565510efe941cee9c1ba3c2db4f0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/freetype/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/freetype/include/freetype-custom-config/ftoption.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Mike West
Created Revert of Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9
3 years, 8 months ago (2017-04-10 09:25:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810643002/1
3 years, 8 months ago (2017-04-10 09:25:40 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 09:27:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66ba5e7e910565510efe941cee9c...

Powered by Google App Engine
This is Rietveld 408576698