Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2786013002: Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9 (Closed)

Created:
3 years, 8 months ago by drott
Modified:
3 years, 8 months ago
Reviewers:
bungeman-chromium
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9 https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/66725768cdf758..5a3490e054bda8 Addresses Clang on Windows LLP64 build failure. BUG=706725 Review-Url: https://codereview.chromium.org/2786013002 Cr-Commit-Position: refs/heads/master@{#463187} Committed: https://chromium.googlesource.com/chromium/src/+/395ac4809e4a98b8745753caf2f3f9015b3ca1f1

Patch Set 1 #

Patch Set 2 : Roll past HVAR/VVAR fixes and linear scaling for unhinted fonts #

Patch Set 3 : Correct revision in README.Chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/freetype/README.chromium View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/freetype/include/freetype-custom-config/ftoption.h View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (22 generated)
bungeman-chromium
lgtm
3 years, 8 months ago (2017-04-05 13:48:49 UTC) #18
drott
Should we go ahead and land this, Ben?
3 years, 8 months ago (2017-04-06 07:07:48 UTC) #21
bungeman-chromium
On 2017/04/06 07:07:48, drott wrote: > Should we go ahead and land this, Ben? I ...
3 years, 8 months ago (2017-04-06 14:26:31 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786013002/40001
3 years, 8 months ago (2017-04-10 06:36:59 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/395ac4809e4a98b8745753caf2f3f9015b3ca1f1
3 years, 8 months ago (2017-04-10 07:57:14 UTC) #27
Mike West
3 years, 8 months ago (2017-04-10 09:25:27 UTC) #28
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2810643002/ by mkwst@chromium.org.

The reason for reverting is: Many CSS layout test failures, starting in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty....

I'm guessing that rolling FreeType in
https://codereview.chromium.org/2786013002/ might have caused these differences,
as it's the only patch in the diff that looks relevant (and because the CQ
didn't run layout tests, which is unfortunate: not sure who's responsible for
the `analyze` step?).
 
BUG=709918.

Powered by Google App Engine
This is Rietveld 408576698