|
|
Created:
3 years, 8 months ago by drott Modified:
3 years, 8 months ago Reviewers:
bungeman-chromium CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9
https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/66725768cdf758..5a3490e054bda8
Addresses Clang on Windows LLP64 build failure.
BUG=706725
Review-Url: https://codereview.chromium.org/2786013002
Cr-Commit-Position: refs/heads/master@{#463187}
Committed: https://chromium.googlesource.com/chromium/src/+/395ac4809e4a98b8745753caf2f3f9015b3ca1f1
Patch Set 1 #Patch Set 2 : Roll past HVAR/VVAR fixes and linear scaling for unhinted fonts #Patch Set 3 : Correct revision in README.Chromium #
Messages
Total messages: 28 (22 generated)
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== Roll FreeType to 1ede3674cbb61888cccaf30a83536654b1c9d4e8 Adresses Clang on Windows LLP64 build failure. BUG=706725 ========== to ========== Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9 https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/667... Addresses Clang on Windows LLP64 build failure. BUG=706725 ==========
The CQ bit was checked by bungeman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Should we go ahead and land this, Ben?
On 2017/04/06 07:07:48, drott wrote: > Should we go ahead and land this, Ben? I have no issues with it.
The CQ bit was checked by drott@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491806212060860, "parent_rev": "8ed8019ada62fac8cbc9c0550202362d9694bdb0", "commit_rev": "395ac4809e4a98b8745753caf2f3f9015b3ca1f1"}
Message was sent while issue was closed.
Description was changed from ========== Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9 https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/667... Addresses Clang on Windows LLP64 build failure. BUG=706725 ========== to ========== Roll FreeType to 5a3490e054bda8a318ebde482c7fb30213cab3d9 https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/667... Addresses Clang on Windows LLP64 build failure. BUG=706725 Review-Url: https://codereview.chromium.org/2786013002 Cr-Commit-Position: refs/heads/master@{#463187} Committed: https://chromium.googlesource.com/chromium/src/+/395ac4809e4a98b8745753caf2f3... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/395ac4809e4a98b8745753caf2f3...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2810643002/ by mkwst@chromium.org. The reason for reverting is: Many CSS layout test failures, starting in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty.... I'm guessing that rolling FreeType in https://codereview.chromium.org/2786013002/ might have caused these differences, as it's the only patch in the diff that looks relevant (and because the CQ didn't run layout tests, which is unfortunate: not sure who's responsible for the `analyze` step?). BUG=709918. |