Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2810413004: Move late-start-testing.js to only user (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move late-start-testing.js to only user The code in resources/late-start-testing.js is used in only one place. Move that code into the one place. The tests were updated to be more thorough in verifying that the initial part is 0, and the first non-zero follows right after. BUG=708778 TEST=oscillator-late-start.html Review-Url: https://codereview.chromium.org/2810413004 Cr-Commit-Position: refs/heads/master@{#466502} Committed: https://chromium.googlesource.com/chromium/src/+/fd42497e9d8fe45ff487d58ac184130bd9ee802d

Patch Set 1 #

Patch Set 2 : Indent correctly. #

Patch Set 3 : Remove file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -57 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html View 1 1 chunk +66 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js View 1 2 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-21 22:06:28 UTC) #4
hongchan
lgtm
3 years, 8 months ago (2017-04-21 22:11:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810413004/60001
3 years, 8 months ago (2017-04-21 22:54:06 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-22 00:04:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fd42497e9d8fe45ff487d58ac184...

Powered by Google App Engine
This is Rietveld 408576698