Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html

Issue 2810413004: Move late-start-testing.js to only user (Closed)
Patch Set: Remove file Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html b/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html
index 6d757bcadf7cec02b7fb3bc87f3718316e646e69..f73424b11b619a4b4c3af06a6932f37137dd505a 100644
--- a/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html
+++ b/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html
@@ -6,23 +6,79 @@
<script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
<script src="../resources/audit.js"></script>
- <script src="../resources/late-start-testing.js"></script>
</head>
<body>
<script>
- var audit = Audit.createTaskRunner();
+ let audit = Audit.createTaskRunner();
- var sampleRate = 44100;
+ let sampleRate = 44100;
+ let renderLength = 1;
- var renderLength = 1;
-
- var context = new OfflineAudioContext(1, sampleRate * renderLength, sampleRate);
- var osc = context.createOscillator();
+ let context;
+ let node;
- // Test the oscillator node is rendered correctly when the start time of start()
- // call is in the past in terms of the context time.
- runLateStartTest(audit, context, osc);
+ // Test the oscillator node is rendered correctly when the start time of
+ // start() call is in the past in terms of the context time.
+ audit.define('initialize', (task, should) => {
+ should(
+ () => context =
+ new OfflineAudioContext(1, sampleRate * renderLength, sampleRate),
+ 'Creating offline context for testing')
+ .notThrow();
+ should(() => {
+ // Set up a dummy signal path to keep the audio context running and
+ // spend processing time before calling start(0).
+ let osc = context.createOscillator();
+ let silent = context.createGain();
+
+ osc.connect(silent);
+ silent.connect(context.destination);
+ silent.gain.setValueAtTime(0.0, 0);
+ osc.start();
+
+ node = context.createOscillator();
+ node.connect(context.destination);
+ }, 'Creating graph for testing').notThrow();
+ task.done();
+ });
+
+ audit.define('test-late-start', (task, should) => {
+ // The node's start time will be clamped to the render quantum boundary
+ // >0.1 sec. Thus the rendered buffer will have non-zero frames.
+ // See issue: crbug.com/462167
+ let suspendTime = 0.1;
+ let suspendFrame = 128 * Math.floor(0.1 * context.sampleRate / 128);
+
+ context.suspend(suspendTime).then(() => {
+ node.start(0);
+ context.resume();
+ });
+
+ // Start rendering and verify result: this verifies if 1) the rendered
+ // buffer contains at least one non-zero value and 2) the non-zero value
+ // is found later than the first output sample.
+ context.startRendering()
+ .then(buffer => {
+ let channelData = buffer.getChannelData(0);
+ let nonZeroValueIndex = channelData.findIndex(x => x != 0);
+
+ should(
+ nonZeroValueIndex,
+ 'The index (' + nonZeroValueIndex +
+ ') of first non-zero output value')
+ .beGreaterThanOrEqualTo(suspendFrame);
+
+ should(
+ channelData.slice(0, suspendFrame),
+ 'Output[0:' + (suspendFrame - 1) + ']')
+ .beConstantValueOf(0);
+ })
+ .then(() => task.done());
+ ;
+ });
+
+ audit.run();
</script>
</body>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698