Extract WebCoreStringResouce out of V8StringResource

Extract WebCoreStringResouce out of V8StringResource

WebCoreStringResource (renamed to StringResource) is used by V8ValueCache and needs to move to platform/bindings.

BUG=682322
Review-Url: https://codereview.chromium.org/2810413003
Cr-Commit-Position: refs/heads/master@{#465286}
Committed: https://chromium.googlesource.com/chromium/src/+/c7c2bd2e10b17a437725111c233184ef430e689b

[adithyas, 2017-04-13 21:23:49]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[adithyas, 2017-04-13 21:24:03]

adithyas@chromium.org changed reviewers:
+ jbroman@chromium.org

[commit-bot: I haz the power, 2017-04-13 21:24:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-04-14 01:20:03]

LGTM

[commit-bot: I haz the power, 2017-04-14 01:28:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 01:28:09]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-04-18 15:37:43]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2017-04-18 15:37:44]

lgtm

https://codereview.chromium.org/2810413003/diff/2/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/StringResource.h (right):

https://codereview.chromium.org/2810413003/diff/2/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/StringResource.h:16: //
StringResource is a helper class for v8ExternalString. It is used
nit: V8ExternalString (post rename)

https://codereview.chromium.org/2810413003/diff/2/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/StringResource.h:132: CORE_EXPORT
StringType V8StringToWebCoreString(v8::Local<v8::String>,
Since you renamed the other references to WebCore (wow, that name takes me
back...), maybe these should be renamed to *ToWTFString or something like that?
This might be a reasonable thing to file as a bug and mark GoodFirstBug.

[adithyas, 2017-04-18 15:52:02]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-04-18 15:52:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2810413003/#ps20001
(title: "Fix comment")

[adithyas, 2017-04-18 15:52:05]

The CQ bit was unchecked by adithyas@chromium.org

[adithyas, 2017-04-18 15:52:22]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-04-18 15:52:23]

https://codereview.chromium.org/2810413003/diff/2/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/StringResource.h (right):

https://codereview.chromium.org/2810413003/diff/2/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/StringResource.h:16: //
StringResource is a helper class for v8ExternalString. It is used
On 2017/04/18 at 15:37:44, jbroman wrote:
> nit: V8ExternalString (post rename)

Fixed.

https://codereview.chromium.org/2810413003/diff/2/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/StringResource.h:132: CORE_EXPORT
StringType V8StringToWebCoreString(v8::Local<v8::String>,
On 2017/04/18 at 15:37:44, jbroman wrote:
> Since you renamed the other references to WebCore (wow, that name takes me
back...), maybe these should be renamed to *ToWTFString or something like that?
This might be a reasonable thing to file as a bug and mark GoodFirstBug.

Ok, I'll file a bug.

[commit-bot: I haz the power, 2017-04-18 15:52:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 18:03:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492530742433040,
"parent_rev": "57176fb7971b00ca01d3df1e88d9dc2c5bb0fd81", "commit_rev":
"c7c2bd2e10b17a437725111c233184ef430e689b"}

[commit-bot: I haz the power, 2017-04-18 18:03:42]

Description was changed from

==========
Extract WebCoreStringResouce out of V8StringResource

WebCoreStringResource (renamed to StringResource) is used by V8ValueCache and
needs to move to platform/bindings.

BUG=682322
==========

to

==========
Extract WebCoreStringResouce out of V8StringResource

WebCoreStringResource (renamed to StringResource) is used by V8ValueCache and
needs to move to platform/bindings.

BUG=682322

Review-Url: https://codereview.chromium.org/2810413003
Cr-Commit-Position: refs/heads/master@{#465286}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7c2bd2e10b17a437725111c2331...
==========

[commit-bot: I haz the power, 2017-04-18 18:03:45]

Committed patchset #3 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c7c2bd2e10b17a437725111c2331...