Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp

Issue 2810413003: Extract WebCoreStringResouce out of V8StringResource (Closed)
Patch Set: Fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp
index 88045e5eb16ff8f375be25a6706e8b1e8e4e7ac6..da82a0274099059ea2aa309c4478480c90e1e2e1 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp
@@ -70,8 +70,7 @@ void StringCache::Dispose() {
static v8::Local<v8::String> MakeExternalString(v8::Isolate* isolate,
const String& string) {
if (string.Is8Bit()) {
- WebCoreStringResource8* string_resource =
- new WebCoreStringResource8(string);
+ StringResource8* string_resource = new StringResource8(string);
v8::Local<v8::String> new_string;
if (!v8::String::NewExternalOneByte(isolate, string_resource)
.ToLocal(&new_string)) {
@@ -81,8 +80,7 @@ static v8::Local<v8::String> MakeExternalString(v8::Isolate* isolate,
return new_string;
}
- WebCoreStringResource16* string_resource =
- new WebCoreStringResource16(string);
+ StringResource16* string_resource = new StringResource16(string);
v8::Local<v8::String> new_string;
if (!v8::String::NewExternalTwoByte(isolate, string_resource)
.ToLocal(&new_string)) {
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698