[Payments] Add metric for when Pr UI is skipped.

[Payments] Add metric for when Pr UI is skipped.

BUG=710996
Review-Url: https://codereview.chromium.org/2810323002
Cr-Commit-Position: refs/heads/master@{#464570}
Committed: https://chromium.googlesource.com/chromium/src/+/31af02951adbf93da81916bfd9746b8f55719cca

[sebsg, 2017-04-12 20:09:50]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 20:10:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-04-12 20:29:52]

sebsg@chromium.org changed reviewers:
+ rouslan@chromium.org

[sebsg, 2017-04-12 20:29:52]

Hi Rouslan, PTAL?

[commit-bot: I haz the power, 2017-04-12 22:05:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 22:05:40]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2017-04-13 13:49:47]

LGTM % comments

https://codereview.chromium.org/2810323002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
(right):

https://codereview.chromium.org/2810323002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java:273:
@CommandLineFlags.Add({"enable-features=" +
ChromeFeatureList.WEB_PAYMENTS_SINGLE_APP_UI_SKIP})
That's enabled by default, no need for a command line flag.

https://cs.chromium.org/chromium/src/chrome/browser/android/chrome_feature_li...

https://codereview.chromium.org/2810323002/diff/1/chrome/test/data/payments/m...
File chrome/test/data/payments/metrics.js (right):

https://codereview.chromium.org/2810323002/diff/1/chrome/test/data/payments/m...
chrome/test/data/payments/metrics.js:56: * Launches the PaymentRequest UI which
accepts only Android Pay and does not
It's better to add a new function than altering the old one. The old one is
still being used in tests, which will cause one of the existing tests to fail.

https://codereview.chromium.org/2810323002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2810323002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:48670: +    method.
s/method/app/

[sebsg, 2017-04-13 19:45:55]

sebsg@chromium.org changed reviewers:
+ holte@chromium.org

[sebsg, 2017-04-13 19:45:56]

Thanks Rouslan,

holte@ could you please review histograms.xml?

Thanks!

https://codereview.chromium.org/2810323002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
(right):

https://codereview.chromium.org/2810323002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java:273:
@CommandLineFlags.Add({"enable-features=" +
ChromeFeatureList.WEB_PAYMENTS_SINGLE_APP_UI_SKIP})
On 2017/04/13 13:49:47, ಠ_ಠ wrote:
> That's enabled by default, no need for a command line flag.
> 
>
https://cs.chromium.org/chromium/src/chrome/browser/android/chrome_feature_li...

Oh thanks, added the opposite test then.

https://codereview.chromium.org/2810323002/diff/1/chrome/test/data/payments/m...
File chrome/test/data/payments/metrics.js (right):

https://codereview.chromium.org/2810323002/diff/1/chrome/test/data/payments/m...
chrome/test/data/payments/metrics.js:56: * Launches the PaymentRequest UI which
accepts only Android Pay and does not
On 2017/04/13 13:49:47, ಠ_ಠ wrote:
> It's better to add a new function than altering the old one. The old one is
> still being used in tests, which will cause one of the existing tests to fail.

Done.

https://codereview.chromium.org/2810323002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2810323002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:48670: +    method.
On 2017/04/13 13:49:47, ಠ_ಠ wrote:
> s/method/app/

Done.

[sebsg, 2017-04-13 20:48:39]

sebsg@chromium.org changed reviewers:
+ jwd@chromium.org
- holte@chromium.org

[sebsg, 2017-04-13 20:48:39]

Hi jwd@ could you please take a look?

[jwd, 2017-04-13 20:53:03]

https://codereview.chromium.org/2810323002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2810323002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:48780: +<histogram
name="PaymentRequest.CheckoutFunnel.SkippedShow" enum="BooleanHit">
What about boolean skipped?

[sebsg, 2017-04-13 21:03:11]

Thanks!

https://codereview.chromium.org/2810323002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2810323002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:48780: +<histogram
name="PaymentRequest.CheckoutFunnel.SkippedShow" enum="BooleanHit">
On 2017/04/13 20:53:03, jwd wrote:
> What about boolean skipped?

Sweet! thanks!

[jwd, 2017-04-13 21:13:06]

lgtm

[jwd, 2017-04-13 21:13:11]

The CQ bit was checked by jwd@chromium.org

[jwd, 2017-04-13 21:13:12]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2810323002/#ps40001
(title: "Use the BooleanSkipped enum")

[commit-bot: I haz the power, 2017-04-13 21:14:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 22:22:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492117991997130,
"parent_rev": "0ca048730748e4b6e774930903f1b2521e4a5fe1", "commit_rev":
"31af02951adbf93da81916bfd9746b8f55719cca"}

[commit-bot: I haz the power, 2017-04-13 22:23:26]

Description was changed from

==========
[Payments] Add metric for when Pr UI is skipped.

BUG=710996
==========

to

==========
[Payments] Add metric for when Pr UI is skipped.

BUG=710996

Review-Url: https://codereview.chromium.org/2810323002
Cr-Commit-Position: refs/heads/master@{#464570}
Committed:
https://chromium.googlesource.com/chromium/src/+/31af02951adbf93da81916bfd974...
==========

[commit-bot: I haz the power, 2017-04-13 22:23:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/31af02951adbf93da81916bfd974...